Modal close button is too dark to see in dark mode #2

New Issue

adrinux · 2021-11-04T18:22:52Z

adrinux commented

2021-11-04 18:22:52 +00:00

It's still possible to close the modal by clicking the edge of the screen but not obvious.

adrinux added the

bug

label 2021-11-04 18:22:57 +00:00

dpschen commented

2021-11-04 20:26:50 +00:00

How about switching background color in dark mode to white so that it lightens the background instead of darken it?

If that looks wrong: I always had the feeling that the background opacity in the "lightmode" is already too strong. If we change that maybe that helps with the dark mode aswell.

As an alternative: different opacity settings for light / dark mode.

How about switching background color in dark mode to white so that it lightens the background instead of darken it? If that looks wrong: I always had the feeling that the background opacity in the "lightmode" is already too strong. If we change that maybe that helps with the dark mode aswell. As an alternative: different opacity settings for light / dark mode.

adrinux commented

2021-11-05 10:37:15 +00:00

It was just something I noticed whilst writing the pull request - it's an element that has been flipped white to black but should probably stay white.

The ideas about opacity and changing the background colour are interesting but I'm not sure this branch is the place to start tinkering with the light theme.

It was just something I noticed whilst writing the pull request - it's an element that has been flipped white to black but should probably stay white. The ideas about opacity and changing the background colour are interesting but I'm not sure this branch is the place to start tinkering with the light theme.

👍 1

adrinux referenced this issue from a commit

2021-11-05 22:17:11 +00:00

Fix #2 - modal close button not visible

adrinux commented

2021-11-05 22:18:54 +00:00

This svg was inheriting the text colour via currentColor, set a different color for .close in dark mode.

Closing.

This svg was inheriting the text colour via currentColor, set a different color for .close in dark mode. Closing.

adrinux closed this issue

2021-11-05 22:18:54 +00:00

dpschen commented

2021-11-06 13:23:55 +00:00

Can you move that in the TaskDetailViewModal.vue with the other .close styles?

Can you move that in the `TaskDetailViewModal.vue` with the other `.close` styles?

adrinux commented

2021-11-08 13:50:15 +00:00

Can you move that in the TaskDetailViewModal.vue with the other .close styles?

Done.
Thanks, knew it was wrong but didn't know where exactly to put it :)

> Can you move that in the `TaskDetailViewModal.vue` with the other `.close` styles? Done. Thanks, knew it was wrong but didn't know where exactly to put it :)

👍 1

Sign in to join this conversation.