• Joined on 2020-02-28
adrinux pushed to master at adrinux/frontend 2021-11-23 14:43:26 +00:00
5ac95e914b Merge remote-tracking branch 'upstream/main'
8f2be6b33e Revert "Add prefers-color-scheme dark media query, reversed color vars"
68e3251ba6 Revert "WIP at converting Bulma/SASS vars to CSS. Enabling prefers-dark mode"
1fb1b01389 Revert "Move grey-500 to hsla and use in shadows"
698ef0d4e9 Revert "Whitespace"
Compare 482 commits »
adrinux commented on issue vikunja/frontend#756 2021-11-23 10:56:41 +00:00
<500 when get issue>

I think with the merging of #954 in 46fa43d67f this is closed.

adrinux closed issue vikunja/frontend#756 2021-11-23 10:56:41 +00:00
<500 when get issue>
adrinux commented on pull request vikunja/frontend#954 2021-11-21 11:58:07 +00:00
Migrate to bulma-css-variables and introduce dark mode

Added end comment, added whitespace back, removed extra hsl in comment

adrinux pushed to bulma-css-variables at adrinux/frontend 2021-11-21 11:57:23 +00:00
5e68122a13 Merge remote-tracking branch 'upstream/main' into bulma-css-variables
709ebdf567 chore(deps): update dependency netlify-cli to v7.0.2
d41ee3dc8c chore(deps): update dependency netlify-cli to v7.0.1
e342f6e3ed fix(deps): update dependency marked to v4.0.4
8b2450d6f9 chore(deps): update dependency postcss-preset-env to v7.0.1
Compare 17 commits »
adrinux pushed to bulma-css-variables at adrinux/frontend 2021-11-21 11:51:34 +00:00
4c6a5916f5 Add end comment, bring back whitespace, remove superfluous hsl in
adrinux commented on pull request vikunja/frontend#954 2021-11-17 20:20:21 +00:00
Migrate to bulma-css-variables and introduce dark mode

Tbh I liked that they were devided by an empty line. How about an end comment, something like:

// END OF Overrides of Bulma defaults

@dpschen You can have end comment if you…

adrinux pushed to bulma-css-variables at adrinux/frontend 2021-11-17 12:22:59 +00:00
5d78cd5b9c Fix build error due to missed dependency during manual resolution of
adrinux pushed to bulma-css-variables at adrinux/frontend 2021-11-16 22:35:01 +00:00
0a156b45a2 Fix: swap bulma for back bulma-css-variables again after merge
db4e9080b9 Merge remote-tracking branch 'upstream/main' into bulma-css-variables
ae5d3ecac5 fix: kanban card spacing (#1005)
26213d5e8c fix: api not found by default
ae0ecb9f23 fix(deps): update sentry-javascript monorepo to v6.15.0 (#1015)
Compare 10 commits »
adrinux commented on issue vikunja/frontend#756 2021-11-16 22:11:20 +00:00
<500 when get issue>

As far as I understand it that file is using thing we don't have in Vikunja so I guess this is not blocking #954?

Exactly, they're all variations on .file-cta class, not something Vikunja…

adrinux pushed to bulma-css-variables at adrinux/frontend 2021-11-16 22:01:05 +00:00
ab89b3c1a6 By @dpschen fix: move one-off exception to place where it is used
adrinux pushed to bulma-css-variables at adrinux/frontend 2021-11-16 21:46:01 +00:00
d923a73827 fix: hack by using color definitions behind variables
60015bb0ad by @dpschen fix: reuse color definition
b65fe8c71c by @dpschen feat: merge location of variables only used in topNavigation
4133363fe1 By @dpschen fix: move logo color definition to logo.vue
Compare 4 commits »
adrinux pushed to bulma-css-variables at adrinux/frontend 2021-11-16 18:21:00 +00:00
f2dc5b643d Review suggestion by dpschen: pagination link color to a color
adrinux commented on pull request vikunja/frontend#954 2021-11-16 18:16:31 +00:00
Migrate to bulma-css-variables and introduce dark mode

That seems perfectly sensible. Done.

adrinux commented on pull request vikunja/frontend#954 2021-11-16 18:14:33 +00:00
Migrate to bulma-css-variables and introduce dark mode

Thought I might need to override them when I started, removed them now.

adrinux commented on pull request vikunja/frontend#954 2021-11-16 18:13:56 +00:00
Migrate to bulma-css-variables and introduce dark mode

Tightened up the whitespace so all the overrides are in one block. That clearer?

adrinux commented on issue vikunja/frontend#756 2021-11-16 18:08:52 +00:00
<500 when get issue>

Might be good to integrate your changes before merge. I was aware that there is not much activity, but I saw this as a way to get to the dark mode as quick as possible, so I guess we are fine…

adrinux pushed to bulma-css-variables at adrinux/frontend 2021-11-16 18:03:22 +00:00
347a77f11b by @dpschen fix: respect .dark class instead of prefers-color-scheme
adrinux pushed to bulma-css-variables at adrinux/frontend 2021-11-16 17:49:59 +00:00
bbf8074285 Clean up, remove whitespace to make comment scope clearer
adrinux commented on issue vikunja/frontend#756 2021-11-16 17:29:01 +00:00
<500 when get issue>

There's also this: https://twitter.com/jgthms/status/1372241503423184898

But since there doesn't seem happen anything around that in bulma I'm not sure how reliable that is.

I got the…