fix: review findings

src/components/tasks/partials/reminder-period.vue

@@ -14,7 +14,7 @@
 							v-model="periodInput.duration.days"
 							type="number"
 							min="0"
-					/> {{ $t('task.reminder.daysShort') }}
+					/> {{ $t('task.reminder.days') }}
 					<input
 							:disabled="disabled"
 							class="input"
@@ -166,7 +166,7 @@ function formatDuration(reminderPeriod: number): string {
 		return '00:00'
 	}
 	const duration = secondsToPeriod(Math.abs(reminderPeriod))
-	return (duration.days > 0 ? duration.days + ' d ' : '') +
+	return (duration.days > 0 ? `${duration.days} ${t('task.reminder.days')} `: '') +
 			('' + duration.hours).padStart(2, '0') + ':' +
 			('' + duration.minutes).padStart(2, '0')
 }

src/helpers/time/period.ts

@@ -3,12 +3,13 @@ import {SECONDS_A_DAY, SECONDS_A_HOUR, SECONDS_A_MINUTE} from '@/constants/date'
 /**
  * Convert time period given as seconds to days, hour, minutes, seconds
  */
-export function secondsToPeriod(seconds: number): {days: number, hours: number, minutes: number, seconds: number} {
-	const d = Math.floor(seconds / SECONDS_A_DAY)
-	const h = Math.floor(seconds % SECONDS_A_DAY / 3600)
-	const m = Math.floor(seconds % SECONDS_A_HOUR / 60)
-	const s = Math.floor(seconds % 60)
-	return {days: d, hours: h, minutes: m, seconds: s}
+export function secondsToPeriod(seconds: number): {days: number, hours: number, minutes: number, seconds: number}  {
+	return {
+		days: Math.floor(seconds / SECONDS_A_DAY),
+		hours: Math.floor(seconds % SECONDS_A_DAY / 3600),
+		minutes: Math.floor(seconds % SECONDS_A_HOUR / 60),
+		seconds: Math.floor(seconds % 60),
+	}
 }
 
 /**

src/i18n/lang/en.json

@@ -723,7 +723,8 @@
     "reminder": {
       "hoursShort": "HH",
       "minutesShort": "MM",
-      "daysShort": "d"
+      "daysShort": "d",
+      "days": "days"
     },
     "repeat": {
       "everyDay": "Every Day",