From 02deb0beddbc9221bdcafd0d09cee383571dae55 Mon Sep 17 00:00:00 2001
From: Dominik Pschenitschni <mail@celement.de>
Date: Mon, 17 Oct 2022 13:41:00 +0200
Subject: [PATCH] feat: rework dropdown-item

---
 src/components/misc/dropdown-item.vue | 45 +++++++--------------------
 src/components/misc/subscription.vue  |  2 +-
 2 files changed, 12 insertions(+), 35 deletions(-)

diff --git a/src/components/misc/dropdown-item.vue b/src/components/misc/dropdown-item.vue
index e1545ae15d..7577e59703 100644
--- a/src/components/misc/dropdown-item.vue
+++ b/src/components/misc/dropdown-item.vue
@@ -1,46 +1,24 @@
 <template>
-	<component
-		:is="componentNodeName"
-		v-bind="elementBindings"
-		:to="to"
-		class="dropdown-item">
+	<BaseButton class="dropdown-item">
 		<span class="icon" v-if="icon">
-			<icon :icon="icon"/>
+			<Icon :icon="icon"/>
 		</span>
 		<span>
-			<slot></slot>
+			<slot  />
 		</span>
-	</component>
+	</BaseButton>
 </template>
 
 <script lang="ts" setup>
-import {ref, useAttrs, watchEffect} from 'vue'
+import BaseButton, { type BaseButtonProps } from '@/components/base//BaseButton.vue'
+import Icon from '@/components/misc/Icon'
+import type { IconProp } from '@fortawesome/fontawesome-svg-core'
 
-const props = defineProps<{
-	to?: object,
-	icon?: string | string[],
-}>()
+export interface DropDownItemProps extends BaseButtonProps {
+	icon?: IconProp,
+}
 
-const componentNodeName = ref<Node['nodeName']>('a')
-const elementBindings = ref({})
-
-const attrs = useAttrs()
-watchEffect(() => {
-	let nodeName = 'a'
-
-	if (props.to) {
-		nodeName = 'router-link'
-	}
-
-	if ('href' in attrs) {
-		nodeName = 'BaseButton'
-	}
-
-	componentNodeName.value = nodeName
-	elementBindings.value = {
-		...attrs,
-	}
-})
+defineProps<DropDownItemProps>()
 </script>
 
 <style scoped lang="scss">
@@ -91,5 +69,4 @@ button.dropdown-item {
 		}
 	}
 }
-
 </style>
diff --git a/src/components/misc/subscription.vue b/src/components/misc/subscription.vue
index 50f1f07193..41beab9517 100644
--- a/src/components/misc/subscription.vue
+++ b/src/components/misc/subscription.vue
@@ -13,7 +13,7 @@
 		v-else-if="type === 'dropdown'"
 		v-tooltip="tooltipText"
 		@click="changeSubscription"
-		:class="{'is-disabled': disabled}"
+		:disabled="disabled"
 		:icon="iconName"
 	>
 		{{ buttonText }}