forked from vikunja/vikunja
konrad
584e3af237
Fix getting avatar based on email Remove avatarUrl from user struct Fix staticcheck Add default avatar size Add config option for caching avatars go mod vendor Add swagger docs Add proxying gravatar requests for user avatars Co-authored-by: kolaente <k@knt.li> Reviewed-on: vikunja/api#148
367 lines
8.9 KiB
Go
367 lines
8.9 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-2020 Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package models
|
|
|
|
import (
|
|
"code.vikunja.io/api/pkg/db"
|
|
"code.vikunja.io/api/pkg/timeutil"
|
|
"code.vikunja.io/api/pkg/user"
|
|
"code.vikunja.io/web"
|
|
"gopkg.in/d4l3k/messagediff.v1"
|
|
"reflect"
|
|
"runtime"
|
|
"testing"
|
|
)
|
|
|
|
func TestNamespaceUser_Create(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
Username string
|
|
NamespaceID int64
|
|
Right Right
|
|
Created timeutil.TimeStamp
|
|
Updated timeutil.TimeStamp
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
type args struct {
|
|
a web.Auth
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "NamespaceUsers Create normally",
|
|
fields: fields{
|
|
Username: "user1",
|
|
NamespaceID: 2,
|
|
},
|
|
},
|
|
{
|
|
name: "NamespaceUsers Create for duplicate",
|
|
fields: fields{
|
|
Username: "user1",
|
|
NamespaceID: 3,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrUserAlreadyHasNamespaceAccess,
|
|
},
|
|
{
|
|
name: "NamespaceUsers Create with invalid right",
|
|
fields: fields{
|
|
Username: "user1",
|
|
NamespaceID: 2,
|
|
Right: 500,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrInvalidRight,
|
|
},
|
|
{
|
|
name: "NamespaceUsers Create with inexisting list",
|
|
fields: fields{
|
|
Username: "user1",
|
|
NamespaceID: 2000,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrNamespaceDoesNotExist,
|
|
},
|
|
{
|
|
name: "NamespaceUsers Create with inexisting user",
|
|
fields: fields{
|
|
Username: "user500",
|
|
NamespaceID: 2,
|
|
},
|
|
wantErr: true,
|
|
errType: user.IsErrUserDoesNotExist,
|
|
},
|
|
{
|
|
name: "NamespaceUsers Create with the owner as shared user",
|
|
fields: fields{
|
|
Username: "user1",
|
|
NamespaceID: 1,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrUserAlreadyHasNamespaceAccess,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
un := &NamespaceUser{
|
|
ID: tt.fields.ID,
|
|
Username: tt.fields.Username,
|
|
NamespaceID: tt.fields.NamespaceID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
err := un.Create(tt.args.a)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("NamespaceUser.Create() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("NamespaceUser.Create() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNamespaceUser_ReadAll(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
UserID int64
|
|
NamespaceID int64
|
|
Right Right
|
|
Created timeutil.TimeStamp
|
|
Updated timeutil.TimeStamp
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
type args struct {
|
|
search string
|
|
a web.Auth
|
|
page int
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
want interface{}
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "Test readall normal",
|
|
fields: fields{
|
|
NamespaceID: 3,
|
|
},
|
|
args: args{
|
|
a: &user.User{ID: 3},
|
|
},
|
|
want: []*UserWithRight{
|
|
{
|
|
User: user.User{
|
|
ID: 1,
|
|
Username: "user1",
|
|
Password: "$2a$14$dcadBoMBL9jQoOcZK8Fju.cy0Ptx2oZECkKLnaa8ekRoTFe1w7To.",
|
|
IsActive: true,
|
|
},
|
|
Right: RightRead,
|
|
},
|
|
{
|
|
User: user.User{
|
|
ID: 2,
|
|
Username: "user2",
|
|
Password: "$2a$14$dcadBoMBL9jQoOcZK8Fju.cy0Ptx2oZECkKLnaa8ekRoTFe1w7To.",
|
|
},
|
|
Right: RightRead,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Test ReadAll by a user who does not have access to the list",
|
|
fields: fields{
|
|
NamespaceID: 3,
|
|
},
|
|
args: args{
|
|
a: &user.User{ID: 4},
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrNeedToHaveNamespaceReadAccess,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
un := &NamespaceUser{
|
|
ID: tt.fields.ID,
|
|
UserID: tt.fields.UserID,
|
|
NamespaceID: tt.fields.NamespaceID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
got, _, _, err := un.ReadAll(tt.args.a, tt.args.search, tt.args.page, 50)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("NamespaceUser.ReadAll() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("NamespaceUser.ReadAll() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
if diff, equal := messagediff.PrettyDiff(got, tt.want); !equal {
|
|
t.Errorf("NamespaceUser.ReadAll() = %v, want %v, diff: %v", got, tt.want, diff)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNamespaceUser_Update(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
Username string
|
|
NamespaceID int64
|
|
Right Right
|
|
Created timeutil.TimeStamp
|
|
Updated timeutil.TimeStamp
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "Test Update Normally",
|
|
fields: fields{
|
|
NamespaceID: 3,
|
|
Username: "user1",
|
|
Right: RightAdmin,
|
|
},
|
|
},
|
|
{
|
|
name: "Test Update to write",
|
|
fields: fields{
|
|
NamespaceID: 3,
|
|
Username: "user1",
|
|
Right: RightWrite,
|
|
},
|
|
},
|
|
{
|
|
name: "Test Update to Read",
|
|
fields: fields{
|
|
NamespaceID: 3,
|
|
Username: "user1",
|
|
Right: RightRead,
|
|
},
|
|
},
|
|
{
|
|
name: "Test Update with invalid right",
|
|
fields: fields{
|
|
NamespaceID: 3,
|
|
Username: "user1",
|
|
Right: 500,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrInvalidRight,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
nu := &NamespaceUser{
|
|
ID: tt.fields.ID,
|
|
Username: tt.fields.Username,
|
|
NamespaceID: tt.fields.NamespaceID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
err := nu.Update()
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("NamespaceUser.Update() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("NamespaceUser.Update() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNamespaceUser_Delete(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
Username string
|
|
NamespaceID int64
|
|
Right Right
|
|
Created timeutil.TimeStamp
|
|
Updated timeutil.TimeStamp
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "Try deleting some unexistant user",
|
|
fields: fields{
|
|
Username: "user1000",
|
|
NamespaceID: 2,
|
|
},
|
|
wantErr: true,
|
|
errType: user.IsErrUserDoesNotExist,
|
|
},
|
|
{
|
|
name: "Try deleting a user which does not has access but exists",
|
|
fields: fields{
|
|
Username: "user1",
|
|
NamespaceID: 4,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrUserDoesNotHaveAccessToNamespace,
|
|
},
|
|
{
|
|
name: "Try deleting normally",
|
|
fields: fields{
|
|
Username: "user1",
|
|
NamespaceID: 3,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
nu := &NamespaceUser{
|
|
ID: tt.fields.ID,
|
|
Username: tt.fields.Username,
|
|
NamespaceID: tt.fields.NamespaceID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
err := nu.Delete()
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("NamespaceUser.Delete() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("NamespaceUser.Delete() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
})
|
|
}
|
|
}
|