perfectra1n
  • Joined on 2023-07-12
perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-11 13:59:20 +00:00
Utilize bjw-s's common Helm library.

What do you think about this change?:

688a055c36

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-11 13:54:08 +00:00
Utilize bjw-s's common Helm library.

Done: 76b209a70c :)

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-11 13:53:51 +00:00
Utilize bjw-s's common Helm library.

Yeah that logic was in the wrong place, that was meant for the Frontend container to "learn" what the API URL was. Fixed: https://kolaente.dev/vikunja/helm-chart/commit/3ea99647e2b2343762d9fe7ce26

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-10 22:42:31 +00:00
Utilize bjw-s's common Helm library.

fixed

d8500214e9

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-10 22:41:46 +00:00
Utilize bjw-s's common Helm library.
perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-10 22:41:34 +00:00
Utilize bjw-s's common Helm library.
perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-10 22:38:34 +00:00
Utilize bjw-s's common Helm library.
perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-10 22:38:21 +00:00
Utilize bjw-s's common Helm library.
perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-10 22:36:58 +00:00
Utilize bjw-s's common Helm library.

Fair, forgot to use the ingress value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an ingress resource (I was even…

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-10 22:32:46 +00:00
Utilize bjw-s's common Helm library.

LOL, I've gotta say, that explains a lot about my own Vikunja deployment after realizing that /api/v1 returns a 401...

fixed!

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-10 22:19:18 +00:00
Utilize bjw-s's common Helm library.

oops, thanks for catching that! fat finger

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-10 17:33:12 +00:00
Utilize bjw-s's common Helm library.

The existing chart has “chart-example.local”, I figured that changing that to “vikunja.local” would be more Vikunja “branded”, if you will, lol.

I can change it back if you would…

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-05 21:20:12 +00:00
Utilize bjw-s's common Helm library.

@konrad should be ready for another readthrough whenever you're free, I'm confident this now both works and delivers on expectations.

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-05 21:06:28 +00:00
Utilize bjw-s's common Helm library.

I mean upgrading from the current chart to the new one.

I see what you're saying - from a user's perspective, what is updating to this version of the Helm chart like. It will definitely…

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-04 23:27:16 +00:00
Utilize bjw-s's common Helm library.

I'm also trying to add some comments to the values.yaml so that a user is less lost when trying to use the Helm chart. I also intend to update the README.md.

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-04 19:52:24 +00:00
Utilize bjw-s's common Helm library.

I went ahead and removed it, the user can add it to each pod as they see fit :)

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-04 19:43:43 +00:00
Utilize bjw-s's common Helm library.

Are you phasing out VIKUNJA_API_URL by chance? I don't see it at https://vikunja.io/docs/config-options/, but I still see it in the injector.sh for the Docker container...

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-04 17:15:40 +00:00
Utilize bjw-s's common Helm library.

I like the general idea of making the chart simpler.

What about the upgrade path?

Not only does it make it simpler, it also allows the user to add/modify the values.yaml to include…

perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-04 17:08:42 +00:00
Utilize bjw-s's common Helm library.

It's a Kubernetes "non-human" user, a Kubernetes-specific object.

ServiceAccount objects in Kubernetes serve several purposes within the cluster:

  1. Provide a distinct identity:…
perfectra1n commented on pull request vikunja/helm-chart#13 2023-10-04 16:57:18 +00:00
Utilize bjw-s's common Helm library.

Upgrade path (like upgrading to newer versions of Vikunja) would just require a user to reference a newer version of the image at the top of values.yaml.