From e8307d254b3d39d6d669cf3b22b91f10ac77c899 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 16 Mar 2023 19:50:52 +0100
Subject: [PATCH] fix(task): make sure the modal close button is not overlapped
 with the title field

---
 src/components/misc/modal.vue             | 5 ++---
 src/components/tasks/partials/heading.vue | 6 +++++-
 src/styles/common-imports.scss            | 2 ++
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/components/misc/modal.vue b/src/components/misc/modal.vue
index 5c1365e96..faebc7dff 100644
--- a/src/components/misc/modal.vue
+++ b/src/components/misc/modal.vue
@@ -193,17 +193,16 @@ $modal-width: 1024px;
 }
 
 .close {
-	$close-button-min-space: 84px;
 	$close-button-padding: 26px;
 	position: fixed;
 	top: 5px;
 	right: $close-button-padding;
 	color: var(--grey-900);
 	font-size: 2rem;
-	
+
 	@media screen and (min-width: $desktop) and (max-width: calc(#{$desktop	} + #{$close-button-min-space})) {
 		top: calc(5px + $modal-margin);
-    right: 50%;
+		right: 50%;
 		// we align the close button to the modal until there is enough space outside for it
 		transform: translateX(calc((#{$modal-width} / 2) - #{$close-button-padding}));
 	}
diff --git a/src/components/tasks/partials/heading.vue b/src/components/tasks/partials/heading.vue
index f6a2b6d61..c3687c765 100644
--- a/src/components/tasks/partials/heading.vue
+++ b/src/components/tasks/partials/heading.vue
@@ -113,7 +113,7 @@ async function save(title: string) {
 <style lang="scss" scoped>
 .heading {
 	display: flex;
-	justify-content: space-between;
+	justify-content: flex-start;
 	text-transform: none;
 	align-items: center;
 
@@ -134,6 +134,10 @@ async function save(title: string) {
 	@media screen and (max-width: $tablet) {
 		margin: 0 -.3rem .5rem -.3rem; // the title has 0.3rem padding - this make the text inside of it align with the rest
 	}
+
+	@media screen and (min-width: $tablet) and (max-width: #{$desktop + $close-button-min-space}) {
+		width: calc(100% - 5rem);
+	}
 }
 
 .title.task-id {
diff --git a/src/styles/common-imports.scss b/src/styles/common-imports.scss
index a383c2c8a..def3264b9 100644
--- a/src/styles/common-imports.scss
+++ b/src/styles/common-imports.scss
@@ -33,3 +33,5 @@ $switch-view-height: 2.69rem;
 
 $navbar-height: 4rem;
 $navbar-width: 300px;
+
+$close-button-min-space: 84px;