From ee99869cf62209984d88de705c653a77fc98d3f8 Mon Sep 17 00:00:00 2001
From: Timo Reichl <timo.reichl@mailbox.org>
Date: Tue, 21 Dec 2021 12:22:17 +0100
Subject: [PATCH] fix: warnings (#1)

* Ran make format

Signed-off-by: Timo Reichl <timo.reichl@mailbox.org>

* Add VS Code launch config

Signed-off-by: Timo Reichl <timo.reichl@mailbox.org>

* pages/list/list.dart: Stop spinning wheel after adding a task

Signed-off-by: Timo Reichl <timo.reichl@mailbox.org>

* stores/list_store.dart: Fix updateTask() not being a future

Signed-off-by: Timo Reichl <timo.reichl@mailbox.org>

* Replace FlatButton with TextButton widgets

Signed-off-by: Timo Reichl <timo.reichl@mailbox.org>

* components/TaskTile.dart: Remove dead code

Signed-off-by: Timo Reichl <timo.reichl@mailbox.org>

* theme/theme.dart: Fix accentColor deprecation

Signed-off-by: Timo Reichl <timo.reichl@mailbox.org>

* pages/list/list_edit.dart: Fix SnackBar.hideCurrentSnackBar() deprecation

Signed-off-by: Timo Reichl <timo.reichl@mailbox.org>

* Remove unused folder lib/managers

Signed-off-by: Timo Reichl <timo.reichl@mailbox.org>
---
 .gitignore                           |   4 +
 .vscode/launch.json                  |  10 +++
 lib/api/client.dart                  |  39 +++++----
 lib/api/label_task.dart              |  10 ++-
 lib/api/label_task_bulk.dart         |   4 +-
 lib/api/labels.dart                  |   9 ++-
 lib/api/list_implementation.dart     |   6 +-
 lib/components/AddDialog.dart        |   4 +-
 lib/components/ErrorDialog.dart      |   2 +-
 lib/components/TaskTile.dart         |  46 +++--------
 lib/components/datetimePicker.dart   |   4 +-
 lib/components/string_extension.dart |   1 -
 lib/global.dart                      |   6 +-
 lib/managers/user.dart               |  24 ------
 lib/models/label.dart                |   1 -
 lib/models/task.dart                 |  10 +--
 lib/models/user.dart                 |   3 +-
 lib/pages/home.dart                  |  65 ++++++++-------
 lib/pages/list/list.dart             | 114 ++++++++++++++-------------
 lib/pages/list/list_edit.dart        |   6 +-
 lib/pages/list/task_edit.dart        |   3 +-
 lib/pages/namespace/namespace.dart   |   7 +-
 lib/service/mocked_services.dart     |   3 +-
 lib/stores/list_store.dart           |  19 +++--
 lib/theme/constants.dart             |   2 +-
 lib/theme/theme.dart                 |   8 +-
 lib/utils/datetime_to_unix.dart      |   2 +-
 27 files changed, 195 insertions(+), 217 deletions(-)
 create mode 100644 .vscode/launch.json
 delete mode 100644 lib/managers/user.dart

diff --git a/.gitignore b/.gitignore
index 48f4ca9..928dd44 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,6 +31,7 @@
 .pub/
 /build/
 ios/Flutter/flutter_export_environment.sh
+analysis_options.yaml
 
 # Web related
 lib/generated_plugin_registrant.dart
@@ -45,3 +46,6 @@ app.*.map.json
 /android/app/debug
 /android/app/profile
 /android/app/release
+
+# VS Code
+.vscode/settings.json
diff --git a/.vscode/launch.json b/.vscode/launch.json
new file mode 100644
index 0000000..1b2ba13
--- /dev/null
+++ b/.vscode/launch.json
@@ -0,0 +1,10 @@
+{
+    "configurations": [
+        {
+            "name": "Flutter",
+            "request": "launch",
+            "type": "dart",
+            "flutterMode": "debug"
+        }
+    ]
+}
diff --git a/lib/api/client.dart b/lib/api/client.dart
index 1fc7158..f2d1f9f 100644
--- a/lib/api/client.dart
+++ b/lib/api/client.dart
@@ -42,28 +42,36 @@ class Client {
         queryParameters: queryParameters,
         // Because dart takes a Map<String, String> here, it is only possible to sort by one parameter while the api supports n parameters.
         fragment: uri.fragment);
-    return http.get(newUri, headers: _headers)
-        .then(_handleResponse);
+    return http.get(newUri, headers: _headers).then(_handleResponse);
   }
 
   Future<Response> delete(String url) {
-    return http.delete('${this.base}$url'.toUri(),
-        headers: _headers,
-    ).then(_handleResponse);
+    return http
+        .delete(
+          '${this.base}$url'.toUri(),
+          headers: _headers,
+        )
+        .then(_handleResponse);
   }
 
   Future<Response> post(String url, {dynamic body}) {
-    return http.post('${this.base}$url'.toUri(),
-        headers: _headers,
-        body: _encoder.convert(body),
-    ).then(_handleResponse);
+    return http
+        .post(
+          '${this.base}$url'.toUri(),
+          headers: _headers,
+          body: _encoder.convert(body),
+        )
+        .then(_handleResponse);
   }
 
   Future<Response> put(String url, {dynamic body}) {
-    return http.put('${this.base}$url'.toUri(),
-        headers: _headers,
-        body: _encoder.convert(body),
-    ).then(_handleResponse);
+    return http
+        .put(
+          '${this.base}$url'.toUri(),
+          headers: _headers,
+          body: _encoder.convert(body),
+        )
+        .then(_handleResponse);
   }
 
   Response _handleResponse(http.Response response) {
@@ -81,10 +89,7 @@ class Client {
           response.statusCode, response.request.url.toString());
     }
     return Response(
-        _decoder.convert(response.body),
-        response.statusCode,
-        response.headers
-    );
+        _decoder.convert(response.body), response.statusCode, response.headers);
   }
 }
 
diff --git a/lib/api/label_task.dart b/lib/api/label_task.dart
index e29011f..c9b1b77 100644
--- a/lib/api/label_task.dart
+++ b/lib/api/label_task.dart
@@ -9,14 +9,16 @@ class LabelTaskAPIService extends APIService implements LabelTaskService {
 
   @override
   Future<Label> create(LabelTask lt) async {
-    return client.put('/tasks/${lt.task.id}/labels', body: lt.toJSON())
+    return client
+        .put('/tasks/${lt.task.id}/labels', body: lt.toJSON())
         .then((result) => Label.fromJson(result.body));
   }
 
   @override
   Future<Label> delete(LabelTask lt) async {
-    return client.delete('/tasks/${lt.task.id}/labels/${lt.label.id}')
-      .then((result) => Label.fromJson(result.body));
+    return client
+        .delete('/tasks/${lt.task.id}/labels/${lt.label.id}')
+        .then((result) => Label.fromJson(result.body));
   }
 
   @override
@@ -27,4 +29,4 @@ class LabelTaskAPIService extends APIService implements LabelTaskService {
     return client.get('/tasks/${lt.task.id}/labels$params').then(
         (label) => convertList(label, (result) => Label.fromJson(result)));
   }
-}
\ No newline at end of file
+}
diff --git a/lib/api/label_task_bulk.dart b/lib/api/label_task_bulk.dart
index 4eef3d8..4a82ef7 100644
--- a/lib/api/label_task_bulk.dart
+++ b/lib/api/label_task_bulk.dart
@@ -14,7 +14,7 @@ class LabelTaskBulkAPIService extends APIService
     return client
         .post('/tasks/${task.id}/labels/bulk',
             body: LabelTaskBulk(labels: labels).toJSON())
-        .then((response) =>
-            convertList(response.body['labels'], (result) => Label.fromJson(result)));
+        .then((response) => convertList(
+            response.body['labels'], (result) => Label.fromJson(result)));
   }
 }
diff --git a/lib/api/labels.dart b/lib/api/labels.dart
index 540e4da..5f2ffba 100644
--- a/lib/api/labels.dart
+++ b/lib/api/labels.dart
@@ -8,19 +8,22 @@ class LabelAPIService extends APIService implements LabelService {
 
   @override
   Future<Label> create(Label label) {
-    return client.put('/labels', body: label.toJSON())
+    return client
+        .put('/labels', body: label.toJSON())
         .then((response) => Label.fromJson(response.body));
   }
 
   @override
   Future<Label> delete(Label label) {
-    return client.delete('/labels/${label.id}')
+    return client
+        .delete('/labels/${label.id}')
         .then((response) => Label.fromJson(response.body));
   }
 
   @override
   Future<Label> get(int labelID) {
-    return client.get('/labels/$labelID')
+    return client
+        .get('/labels/$labelID')
         .then((response) => Label.fromJson(response.body));
   }
 
diff --git a/lib/api/list_implementation.dart b/lib/api/list_implementation.dart
index bb6c5f8..61a8ccf 100644
--- a/lib/api/list_implementation.dart
+++ b/lib/api/list_implementation.dart
@@ -30,9 +30,9 @@ class ListAPIService extends APIService implements ListService {
     return client.get('/lists/$listId').then((response) {
       final map = response.body;
       if (map.containsKey('id')) {
-        return client.get("/lists/$listId/tasks")
-            .then((tasks) => TaskList.fromJson(
-              map, tasksJson: tasks.body));
+        return client
+            .get("/lists/$listId/tasks")
+            .then((tasks) => TaskList.fromJson(map, tasksJson: tasks.body));
       }
       return TaskList.fromJson(map);
     });
diff --git a/lib/components/AddDialog.dart b/lib/components/AddDialog.dart
index 6cb56ca..15b1aec 100644
--- a/lib/components/AddDialog.dart
+++ b/lib/components/AddDialog.dart
@@ -21,11 +21,11 @@ class AddDialog extends StatelessWidget {
         )
       ]),
       actions: <Widget>[
-        new FlatButton(
+        new TextButton(
           child: const Text('CANCEL'),
           onPressed: () => Navigator.pop(context),
         ),
-        new FlatButton(
+        new TextButton(
           child: const Text('ADD'),
           onPressed: () {
             if (this.onAdd != null && textController.text.isNotEmpty)
diff --git a/lib/components/ErrorDialog.dart b/lib/components/ErrorDialog.dart
index 640c3c1..a837974 100644
--- a/lib/components/ErrorDialog.dart
+++ b/lib/components/ErrorDialog.dart
@@ -10,7 +10,7 @@ class ErrorDialog extends StatelessWidget {
     return AlertDialog(
       content: Text(error.toString()),
       actions: <Widget>[
-        FlatButton(
+        TextButton(
           child: Text('Close'),
           onPressed: () => Navigator.of(context).maybePop(),
         )
diff --git a/lib/components/TaskTile.dart b/lib/components/TaskTile.dart
index 4c6a372..ca2e253 100644
--- a/lib/components/TaskTile.dart
+++ b/lib/components/TaskTile.dart
@@ -1,7 +1,6 @@
 import 'dart:async';
 
 import 'package:flutter/material.dart';
-import 'package:vikunja_app/global.dart';
 import 'package:vikunja_app/models/task.dart';
 
 class TaskTile extends StatefulWidget {
@@ -21,17 +20,16 @@ class TaskTile extends StatefulWidget {
 
   @override
   TaskTileState createState() {
-    return new TaskTileState(this.task, this.loading);
+    return new TaskTileState(this.loading);
   }
 }
 
 class TaskTileState extends State<TaskTile> {
   bool _loading;
-  Task _currentTask;
 
-  TaskTileState(this._currentTask, this._loading)
-      : assert(_currentTask != null),
-        assert(_loading != null);
+  TaskTileState(this._loading) {
+    assert(_loading != null);
+  }
 
   @override
   Widget build(BuildContext context) {
@@ -47,9 +45,10 @@ class TaskTileState extends State<TaskTile> {
               )),
         ),
         title: Text(widget.task.title),
-        subtitle: widget.task.description == null || widget.task.description.isEmpty
-            ? null
-            : Text(widget.task.description),
+        subtitle:
+            widget.task.description == null || widget.task.description.isEmpty
+                ? null
+                : Text(widget.task.description),
         trailing: IconButton(
           icon: Icon(Icons.settings),
           onPressed: () => widget.onEdit,
@@ -60,9 +59,10 @@ class TaskTileState extends State<TaskTile> {
       title: Text(widget.task.title),
       controlAffinity: ListTileControlAffinity.leading,
       value: widget.task.done ?? false,
-      subtitle: widget.task.description == null || widget.task.description.isEmpty
-          ? null
-          : Text(widget.task.description),
+      subtitle:
+          widget.task.description == null || widget.task.description.isEmpty
+              ? null
+              : Text(widget.task.description),
       secondary: IconButton(
         icon: Icon(Icons.settings),
         onPressed: widget.onEdit,
@@ -70,28 +70,6 @@ class TaskTileState extends State<TaskTile> {
       onChanged: widget.onMarkedAsDone,
     );
   }
-
-  void _change(bool value) async {
-    setState(() {
-      this._loading = true;
-    });
-    Task newTask = await _updateTask(widget.task, value);
-    setState(() {
-      //this.widget.task = newTask;
-      this._loading = false;
-    });
-  }
-
-  Future<Task> _updateTask(Task task, bool checked) {
-    // TODO use copyFrom
-    return VikunjaGlobal.of(context).taskService.update(Task(
-          id: task.id,
-          done: checked,
-          title: task.title,
-          description: task.description,
-          createdBy: null,
-        ));
-  }
 }
 
 typedef Future<void> TaskChanged(Task task, bool newValue);
diff --git a/lib/components/datetimePicker.dart b/lib/components/datetimePicker.dart
index 9a72782..ff7eab4 100644
--- a/lib/components/datetimePicker.dart
+++ b/lib/components/datetimePicker.dart
@@ -43,7 +43,9 @@ class VikunjaDateTimePicker extends StatelessWidget {
         return showDatePicker(
             context: context,
             firstDate: DateTime(1900),
-            initialDate: currentValue.millisecondsSinceEpoch > 0 ? currentValue : DateTime.now(),
+            initialDate: currentValue.millisecondsSinceEpoch > 0
+                ? currentValue
+                : DateTime.now(),
             lastDate: DateTime(2100));
       },
     );
diff --git a/lib/components/string_extension.dart b/lib/components/string_extension.dart
index a9360e2..edcbe13 100644
--- a/lib/components/string_extension.dart
+++ b/lib/components/string_extension.dart
@@ -1,4 +1,3 @@
 extension StringExtensions on String {
-
   Uri toUri() => Uri.tryParse(this);
 }
diff --git a/lib/global.dart b/lib/global.dart
index 4825bb7..fcb7866 100644
--- a/lib/global.dart
+++ b/lib/global.dart
@@ -8,7 +8,6 @@ import 'package:vikunja_app/api/list_implementation.dart';
 import 'package:vikunja_app/api/namespace_implementation.dart';
 import 'package:vikunja_app/api/task_implementation.dart';
 import 'package:vikunja_app/api/user_implementation.dart';
-import 'package:vikunja_app/managers/user.dart';
 import 'package:vikunja_app/models/user.dart';
 import 'package:vikunja_app/service/services.dart';
 
@@ -22,7 +21,8 @@ class VikunjaGlobal extends StatefulWidget {
   VikunjaGlobalState createState() => VikunjaGlobalState();
 
   static VikunjaGlobalState of(BuildContext context) {
-    var widget = context.dependOnInheritedWidgetOfExactType<_VikunjaGlobalInherited>();
+    var widget =
+        context.dependOnInheritedWidgetOfExactType<_VikunjaGlobalInherited>();
     return widget.data;
   }
 }
@@ -38,8 +38,6 @@ class VikunjaGlobalState extends State<VikunjaGlobal> {
 
   Client get client => _client;
 
-  UserManager get userManager => new UserManager(_storage);
-
   UserService newUserService(base) => new UserAPIService(Client(null, base));
 
   NamespaceService get namespaceService => new NamespaceAPIService(client);
diff --git a/lib/managers/user.dart b/lib/managers/user.dart
deleted file mode 100644
index 15fb315..0000000
--- a/lib/managers/user.dart
+++ /dev/null
@@ -1,24 +0,0 @@
-import 'dart:async';
-
-import 'package:flutter_secure_storage/flutter_secure_storage.dart';
-
-class UserManager {
-  final FlutterSecureStorage _storage;
-
-  UserManager(this._storage);
-
-  Future<List<int>> loadLocalUserIds() async {
-    return await _storage.readAll().then((userMap) {
-      userMap.keys
-          .where((id) => _isNumeric(id))
-          .map((idString) => int.tryParse(idString));
-    });
-  }
-
-  bool _isNumeric(String str) {
-    if (str == null) {
-      return false;
-    }
-    return double.tryParse(str) != null;
-  }
-}
diff --git a/lib/models/label.dart b/lib/models/label.dart
index 01ecbd7..607bcbb 100644
--- a/lib/models/label.dart
+++ b/lib/models/label.dart
@@ -1,6 +1,5 @@
 import 'dart:ui';
 
-import 'package:meta/meta.dart';
 import 'package:vikunja_app/models/user.dart';
 
 class Label {
diff --git a/lib/models/task.dart b/lib/models/task.dart
index 3dcca6e..dce3ea4 100644
--- a/lib/models/task.dart
+++ b/lib/models/task.dart
@@ -3,7 +3,6 @@ import 'package:json_annotation/json_annotation.dart';
 
 import 'package:vikunja_app/models/label.dart';
 import 'package:vikunja_app/models/user.dart';
-import 'package:vikunja_app/utils/datetime_to_unix.dart';
 
 @JsonSerializable()
 class Task {
@@ -60,16 +59,17 @@ class Task {
             ?.toList(),
         updated = DateTime.parse(json['updated']),
         created = DateTime.parse(json['created']),
-        createdBy = json['created_by'] == null ? null : User.fromJson(json['created_by']);
+        createdBy = json['created_by'] == null
+            ? null
+            : User.fromJson(json['created_by']);
 
   toJSON() => {
         'id': id,
         'title': title,
         'description': description,
         'done': done ?? false,
-        'reminder_dates': reminderDates
-            ?.map((date) => date?.toIso8601String())
-            ?.toList(),
+        'reminder_dates':
+            reminderDates?.map((date) => date?.toIso8601String())?.toList(),
         'due_date': dueDate?.toIso8601String(),
         'start_date': startDate?.toIso8601String(),
         'end_date': endDate?.toIso8601String(),
diff --git a/lib/models/user.dart b/lib/models/user.dart
index f39b3c3..6ccd13c 100644
--- a/lib/models/user.dart
+++ b/lib/models/user.dart
@@ -14,8 +14,7 @@ class User {
   toJSON() => {"id": this.id, "email": this.email, "username": this.username};
 
   String avatarUrl(BuildContext context) {
-    return VikunjaGlobal.of(context).client.base +
-        "/avatar/${this.username}";
+    return VikunjaGlobal.of(context).client.base + "/avatar/${this.username}";
   }
 }
 
diff --git a/lib/pages/home.dart b/lib/pages/home.dart
index ff77388..abc3f53 100644
--- a/lib/pages/home.dart
+++ b/lib/pages/home.dart
@@ -33,24 +33,21 @@ class HomePageState extends State<HomePage> with AfterLayoutMixin<HomePage> {
 
   Widget _namespacesWidget() {
     List<Widget> namespacesList = <Widget>[];
-    _namespaces
-        .asMap()
-        .forEach((i, namespace) => namespacesList.add(ListTile(
-              leading: const Icon(Icons.folder),
-              title: Text(namespace.title),
-              selected: i == _selectedDrawerIndex,
-              onTap: () => _onSelectItem(i),
-            ))
-    );
+    _namespaces.asMap().forEach((i, namespace) => namespacesList.add(ListTile(
+          leading: const Icon(Icons.folder),
+          title: Text(namespace.title),
+          selected: i == _selectedDrawerIndex,
+          onTap: () => _onSelectItem(i),
+        )));
 
     return this._loading
         ? Center(child: CircularProgressIndicator())
         : RefreshIndicator(
             child: ListView(
-                padding: EdgeInsets.zero,
-                children: ListTile.divideTiles(
-                    context: context,
-                    tiles: namespacesList).toList(),
+              padding: EdgeInsets.zero,
+              children:
+                  ListTile.divideTiles(context: context, tiles: namespacesList)
+                      .toList(),
             ),
             onRefresh: _loadNamespaces,
           );
@@ -85,18 +82,18 @@ class HomePageState extends State<HomePage> with AfterLayoutMixin<HomePage> {
                         MaterialPageRoute(
                             builder: (context) => NamespaceEditPage(
                                   namespace: _currentNamespace,
-                                )
-                        )
-                    )
-                ),
+                                )))),
               ],
       ),
       drawer: Drawer(
         child: Column(children: <Widget>[
           UserAccountsDrawerHeader(
             // Removed until we find a way to disable the user email only for some occasions and not everywhere
-            accountEmail: currentUser?.email == null ? null : Text(currentUser.email),
-            accountName: currentUser?.username == null ? null : Text(currentUser.username),
+            accountEmail:
+                currentUser?.email == null ? null : Text(currentUser.email),
+            accountName: currentUser?.username == null
+                ? null
+                : Text(currentUser.username),
             onDetailsPressed: () {
               setState(() {
                 _showUserDetails = !_showUserDetails;
@@ -105,22 +102,24 @@ class HomePageState extends State<HomePage> with AfterLayoutMixin<HomePage> {
             currentAccountPicture: currentUser == null
                 ? null
                 : CircleAvatar(
-                    backgroundImage: NetworkImage(currentUser.avatarUrl(context)),
+                    backgroundImage:
+                        NetworkImage(currentUser.avatarUrl(context)),
                   ),
             decoration: BoxDecoration(
               image: DecorationImage(
-                  image: AssetImage("assets/graphics/hypnotize.png"),
-                  repeat: ImageRepeat.repeat,
-                  colorFilter: ColorFilter.mode(Theme.of(context).primaryColor, BlendMode.multiply),
+                image: AssetImage("assets/graphics/hypnotize.png"),
+                repeat: ImageRepeat.repeat,
+                colorFilter: ColorFilter.mode(
+                    Theme.of(context).primaryColor, BlendMode.multiply),
               ),
             ),
           ),
           Builder(
-              builder: (BuildContext context) =>
-                  Expanded(
-                    child: _showUserDetails ? _userDetailsWidget(context) : _namespacesWidget(),
-                  )
-          ),
+              builder: (BuildContext context) => Expanded(
+                    child: _showUserDetails
+                        ? _userDetailsWidget(context)
+                        : _namespacesWidget(),
+                  )),
           Align(
             alignment: FractionalOffset.bottomCenter,
             child: Builder(
@@ -155,8 +154,8 @@ class HomePageState extends State<HomePage> with AfterLayoutMixin<HomePage> {
         builder: (_) => AddDialog(
               onAdd: (name) => _addNamespace(name, context),
               decoration: InputDecoration(
-                  labelText: 'Namespace',
-                  hintText: 'eg. Personal Namespace',
+                labelText: 'Namespace',
+                hintText: 'eg. Personal Namespace',
               ),
             ));
   }
@@ -171,9 +170,9 @@ class HomePageState extends State<HomePage> with AfterLayoutMixin<HomePage> {
         content: Text('The namespace was created successfully!'),
       ));
     }).catchError((error) => showDialog(
-        context: context,
-        builder: (context) => ErrorDialog(error: error),
-    ));
+              context: context,
+              builder: (context) => ErrorDialog(error: error),
+            ));
   }
 
   Future<void> _loadNamespaces() {
diff --git a/lib/pages/list/list.dart b/lib/pages/list/list.dart
index c84fe7f..5e18e50 100644
--- a/lib/pages/list/list.dart
+++ b/lib/pages/list/list.dart
@@ -11,7 +11,6 @@ import 'package:vikunja_app/pages/list/list_edit.dart';
 import 'package:vikunja_app/pages/list/task_edit.dart';
 import 'package:vikunja_app/stores/list_store.dart';
 
-
 class ListPage extends StatefulWidget {
   final TaskList taskList;
 
@@ -41,63 +40,62 @@ class _ListPageState extends State<ListPage> {
   Widget build(BuildContext context) {
     final taskState = Provider.of<ListProvider>(context);
     return Scaffold(
-        appBar: AppBar(
-          title: Text(_list.title),
-          actions: <Widget>[
-            IconButton(
-              icon: Icon(Icons.edit),
-              onPressed: () => Navigator.push(
-                  context,
-                  MaterialPageRoute(
-                      builder: (context) => ListEditPage(
-                        list: _list,
-                      ),
-                  )
-                ),
-            ),
-          ],
-        ),
-        // TODO: it brakes the flow with _loadingTasks and conflicts with the provider
-        body: !taskState.isLoading
-            ? RefreshIndicator(
-                child: taskState.tasks.length > 0
+      appBar: AppBar(
+        title: Text(_list.title),
+        actions: <Widget>[
+          IconButton(
+            icon: Icon(Icons.edit),
+            onPressed: () => Navigator.push(
+                context,
+                MaterialPageRoute(
+                  builder: (context) => ListEditPage(
+                    list: _list,
+                  ),
+                )),
+          ),
+        ],
+      ),
+      // TODO: it brakes the flow with _loadingTasks and conflicts with the provider
+      body: !taskState.isLoading
+          ? RefreshIndicator(
+              child: taskState.tasks.length > 0
                   ? ListenableProvider.value(
                       value: taskState,
                       child: ListView.builder(
-                        padding: EdgeInsets.symmetric(vertical: 8.0),
-                        itemBuilder: (context, i) {
-                          if (i.isOdd) return Divider();
+                          padding: EdgeInsets.symmetric(vertical: 8.0),
+                          itemBuilder: (context, i) {
+                            if (i.isOdd) return Divider();
 
-                          if (_loadingTasks.isNotEmpty) {
-                            final loadingTask = _loadingTasks.removeLast();
-                            return _buildLoadingTile(loadingTask);
-                          }
+                            if (_loadingTasks.isNotEmpty) {
+                              final loadingTask = _loadingTasks.removeLast();
+                              return _buildLoadingTile(loadingTask);
+                            }
 
-                          final index = i ~/ 2;
+                            final index = i ~/ 2;
 
-                          // This handles the case if there are no more elements in the list left which can be provided by the api
-                          if (taskState.maxPages == _currentPage &&
-                              index == taskState.tasks.length - 1) return null;
+                            // This handles the case if there are no more elements in the list left which can be provided by the api
+                            if (taskState.maxPages == _currentPage &&
+                                index == taskState.tasks.length - 1)
+                              return null;
 
-                          if (index >= taskState.tasks.length &&
-                              _currentPage < taskState.maxPages) {
-                            _currentPage++;
-                            _loadTasksForPage(_currentPage);
-                          }
-                          return index < taskState.tasks.length
-                              ? _buildTile(taskState.tasks[index])
-                              : null;
-                        }
-                    ),
-                  )
+                            if (index >= taskState.tasks.length &&
+                                _currentPage < taskState.maxPages) {
+                              _currentPage++;
+                              _loadTasksForPage(_currentPage);
+                            }
+                            return index < taskState.tasks.length
+                                ? _buildTile(taskState.tasks[index])
+                                : null;
+                          }),
+                    )
                   : Center(child: Text('This list is empty.')),
-                onRefresh: _loadList,
+              onRefresh: _loadList,
             )
-            : Center(child: CircularProgressIndicator()),
-        floatingActionButton: Builder(
-          builder: (context) => FloatingActionButton(
-              onPressed: () => _addItemDialog(context), child: Icon(Icons.add)),
-          ),
+          : Center(child: CircularProgressIndicator()),
+      floatingActionButton: Builder(
+        builder: (context) => FloatingActionButton(
+            onPressed: () => _addItemDialog(context), child: Icon(Icons.add)),
+      ),
     );
   }
 
@@ -156,8 +154,8 @@ class _ListPageState extends State<ListPage> {
       builder: (_) => AddDialog(
         onAdd: (title) => _addItem(title, context),
         decoration: InputDecoration(
-            labelText: 'Task Name',
-            hintText: 'eg. Milk',
+          labelText: 'Task Name',
+          hintText: 'eg. Milk',
         ),
       ),
     );
@@ -174,13 +172,17 @@ class _ListPageState extends State<ListPage> {
     setState(() => _loadingTasks.add(newTask));
     Provider.of<ListProvider>(context, listen: false)
         .addTask(
-          context: context,
-          newTask: newTask,
-          listId: _list.id,
-    ).then((_) {
+      context: context,
+      newTask: newTask,
+      listId: _list.id,
+    )
+        .then((_) {
       ScaffoldMessenger.of(context).showSnackBar(SnackBar(
         content: Text('The task was added successfully!'),
       ));
+      setState(() {
+        _loadingTasks.remove(newTask);
+      });
     });
   }
-}
\ No newline at end of file
+}
diff --git a/lib/pages/list/list_edit.dart b/lib/pages/list/list_edit.dart
index 88a0e65..684032f 100644
--- a/lib/pages/list/list_edit.dart
+++ b/lib/pages/list/list_edit.dart
@@ -106,12 +106,14 @@ class _ListEditPageState extends State<ListEditPage> {
       ));
     }).catchError((err) {
       setState(() => _loading = false);
-      ScaffoldMessenger.of(context).showSnackBar(
+      ScaffoldMessengerState scaffoldState = ScaffoldMessenger.of(context);
+      scaffoldState.showSnackBar(
         SnackBar(
           content: Text('Something went wrong: ' + err.toString()),
           action: SnackBarAction(
               label: 'CLOSE',
-              onPressed: Scaffold.of(context).hideCurrentSnackBar),
+              onPressed: (() => scaffoldState.hideCurrentSnackBar(
+                  reason: SnackBarClosedReason.action))),
         ),
       );
     });
diff --git a/lib/pages/list/task_edit.dart b/lib/pages/list/task_edit.dart
index 6f536b4..7529d49 100644
--- a/lib/pages/list/task_edit.dart
+++ b/lib/pages/list/task_edit.dart
@@ -59,7 +59,8 @@ class _TaskEditPageState extends State<TaskEditPage> {
         builder: (BuildContext context) => SafeArea(
           child: Form(
             key: _formKey,
-            child: ListView(padding: const EdgeInsets.all(16.0), children: <Widget>[
+            child: ListView(padding: const EdgeInsets.all(16.0), children: <
+                Widget>[
               Padding(
                 padding: EdgeInsets.symmetric(vertical: 10.0),
                 child: TextFormField(
diff --git a/lib/pages/namespace/namespace.dart b/lib/pages/namespace/namespace.dart
index fd1a0c5..87e2094 100644
--- a/lib/pages/namespace/namespace.dart
+++ b/lib/pages/namespace/namespace.dart
@@ -58,8 +58,11 @@ class _NamespacePageState extends State<NamespacePage>
                                           color: Colors.white, size: 36.0)),
                                 ),
                                 onDismissed: (direction) {
-                                  _removeList(ls).then((_) => ScaffoldMessenger.of(context)
-                                      .showSnackBar(SnackBar(content: Text("${ls.title} removed"))));
+                                  _removeList(ls).then((_) =>
+                                      ScaffoldMessenger.of(context)
+                                          .showSnackBar(SnackBar(
+                                              content: Text(
+                                                  "${ls.title} removed"))));
                                 },
                               ))).toList(),
                     )
diff --git a/lib/service/mocked_services.dart b/lib/service/mocked_services.dart
index 799fbdf..484b7e2 100644
--- a/lib/service/mocked_services.dart
+++ b/lib/service/mocked_services.dart
@@ -122,8 +122,7 @@ class MockedTaskService implements TaskService {
   @override
   Future delete(int taskId) {
     _lists.forEach(
-        (_, list) => list.tasks.removeWhere((task) => task.id == taskId)
-    );
+        (_, list) => list.tasks.removeWhere((task) => task.id == taskId));
     _tasks.remove(taskId);
     return Future.value();
   }
diff --git a/lib/stores/list_store.dart b/lib/stores/list_store.dart
index 70f00a0..cc4e7a3 100644
--- a/lib/stores/list_store.dart
+++ b/lib/stores/list_store.dart
@@ -39,13 +39,14 @@ class ListProvider with ChangeNotifier {
     });
   }
 
-  Future<void> addTaskByTitle({BuildContext context, String title, int listId}) {
+  Future<void> addTaskByTitle(
+      {BuildContext context, String title, int listId}) {
     var globalState = VikunjaGlobal.of(context);
     var newTask = Task(
-        id: null,
-        title: title,
-        createdBy: globalState.currentUser,
-        done: false,
+      id: null,
+      title: title,
+      createdBy: globalState.currentUser,
+      done: false,
     );
     _isLoading = true;
     notifyListeners();
@@ -69,12 +70,14 @@ class ListProvider with ChangeNotifier {
     });
   }
 
-  Future<void> updateTask({BuildContext context, int id, bool done}) {
+  void updateTask({BuildContext context, int id, bool done}) {
     var globalState = VikunjaGlobal.of(context);
-    globalState.taskService.update(Task(
+    globalState.taskService
+        .update(Task(
       id: id,
       done: done,
-    )).then((task) {
+    ))
+        .then((task) {
       // FIXME: This is ugly. We should use a redux to not have to do these kind of things.
       //  This is enough for now (it works™) but we should definitly fix it later.
       _tasks.asMap().forEach((i, t) {
diff --git a/lib/theme/constants.dart b/lib/theme/constants.dart
index b2fc6ae..e909971 100644
--- a/lib/theme/constants.dart
+++ b/lib/theme/constants.dart
@@ -30,4 +30,4 @@ const vStandardVerticalPadding = EdgeInsets.symmetric(vertical: 5.0);
 const vStandardHorizontalPadding = EdgeInsets.symmetric(horizontal: 5.0);
 const vStandardPadding = EdgeInsets.symmetric(horizontal: 5.0, vertical: 5.0);
 
-var vDateFormatLong = DateFormat("EEEE, MMMM d, yyyy 'at' H:mm");
\ No newline at end of file
+var vDateFormatLong = DateFormat("EEEE, MMMM d, yyyy 'at' H:mm");
diff --git a/lib/theme/theme.dart b/lib/theme/theme.dart
index 7825031..7fddf64 100644
--- a/lib/theme/theme.dart
+++ b/lib/theme/theme.dart
@@ -2,13 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:vikunja_app/theme/constants.dart';
 
 ThemeData buildVikunjaTheme() => _buildVikunjaTheme(ThemeData.light());
-
-ThemeData buildVikunjaDarkTheme() {
-  ThemeData base = _buildVikunjaTheme(ThemeData.dark());
-  return base.copyWith(
-    accentColor: vWhite,
-  );
-}
+ThemeData buildVikunjaDarkTheme() => _buildVikunjaTheme(ThemeData.dark());
 
 ThemeData _buildVikunjaTheme(ThemeData base) {
   return base.copyWith(
diff --git a/lib/utils/datetime_to_unix.dart b/lib/utils/datetime_to_unix.dart
index d44a342..db48e48 100644
--- a/lib/utils/datetime_to_unix.dart
+++ b/lib/utils/datetime_to_unix.dart
@@ -8,4 +8,4 @@ dateTimeFromUnixTimestamp(int timestamp) {
   return timestamp == null
       ? 0
       : DateTime.fromMillisecondsSinceEpoch(timestamp * 1000);
-}
\ No newline at end of file
+}