From 16a300d9c476f234e0bbf74f75de17cd52dc27f4 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Tue, 28 Mar 2023 21:31:38 +0200
Subject: [PATCH] fix: make computed side-effect free

---
 src/views/tasks/TaskDetailView.vue | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/src/views/tasks/TaskDetailView.vue b/src/views/tasks/TaskDetailView.vue
index bcf075945..6c2c11944 100644
--- a/src/views/tasks/TaskDetailView.vue
+++ b/src/views/tasks/TaskDetailView.vue
@@ -447,7 +447,7 @@
 </template>
 
 <script lang="ts" setup>
-import {ref, reactive, toRef, shallowReactive, computed, watch, nextTick, type PropType} from 'vue'
+import {ref, reactive, toRef, shallowReactive, computed, watch, watchEffect, nextTick, type PropType} from 'vue'
 import {useRouter, type RouteLocation} from 'vue-router'
 import {useI18n} from 'vue-i18n'
 import {unrefElement} from '@vueuse/core'
@@ -536,16 +536,11 @@ const visible = ref(false)
 
 const taskId = toRef(props, 'taskId')
 
-const project = computed(() => {
-	if (!task.projectId) {
-		return {
-			project: null,
-		}
-	}
-
-	const project = projectStore.getProjectById(task.projectId)
-	baseStore.handleSetCurrentProject({project})
-	return project
+const project = computed(() => task.projectId ? projectStore.getProjectById(task.projectId) : null)
+watchEffect(() => {
+	baseStore.handleSetCurrentProject({
+		project: project.value,
+	})
 })
 
 const canWrite = computed(() => (