[alphabetical-sort] Review fixes
continuous-integration/drone/pr Build is failing Details

This commit is contained in:
Stefan Genov 2021-12-15 09:02:32 +02:00
parent 6b5d72da72
commit 1b6d50860c
16 changed files with 4 additions and 21 deletions

View File

@ -195,7 +195,7 @@ import NamespaceService from '@/services/namespace'
import EditLabels from '@/components/tasks/partials/editLabels.vue' import EditLabels from '@/components/tasks/partials/editLabels.vue'
import {objectToSnakeCase} from '@/helpers/case' import {objectToSnakeCase} from '@/helpers/case'
import {getDefaultParams} from "../../tasks/mixins/taskList" import {getDefaultParams} from '../../tasks/mixins/taskList'
// FIXME: merge with DEFAULT_PARAMS in taskList.js // FIXME: merge with DEFAULT_PARAMS in taskList.js
const DEFAULT_PARAMS = { const DEFAULT_PARAMS = {
@ -226,6 +226,8 @@ const DEFAULT_FILTERS = {
namespace: '', namespace: '',
} }
const ALPHABETICAL_SORT = ['title']
export default { export default {
name: 'filters', name: 'filters',
components: { components: {
@ -503,7 +505,7 @@ export default {
this.params.sort_by = getDefaultParams().sort_by this.params.sort_by = getDefaultParams().sort_by
this.sortAlphabetically = false this.sortAlphabetically = false
} else { } else {
this.params.sort_by = ['title'] this.params.sort_by = ALPHABETICAL_SORT
this.sortAlphabetically = true this.sortAlphabetically = true
} }
this.change() this.change()

View File

@ -373,7 +373,6 @@
"includeNulls": "Zahrnout úkoly, které nemají nastavenou hodnotu", "includeNulls": "Zahrnout úkoly, které nemají nastavenou hodnotu",
"requireAll": "Vyžaduje aby všechny filtry odpovídaly, aby se úkol zobrazil", "requireAll": "Vyžaduje aby všechny filtry odpovídaly, aby se úkol zobrazil",
"showDoneTasks": "Zobrazit dokončené úkoly", "showDoneTasks": "Zobrazit dokončené úkoly",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Povolit filtrování podle priority", "enablePriority": "Povolit filtrování podle priority",
"enablePercentDone": "Povolit filtrování dle dokončenosti", "enablePercentDone": "Povolit filtrování dle dokončenosti",
"dueDateRange": "Rozsah termínu", "dueDateRange": "Rozsah termínu",

View File

@ -373,7 +373,6 @@
"includeNulls": "Aufgaben ohne Werte einbeziehen", "includeNulls": "Aufgaben ohne Werte einbeziehen",
"requireAll": "Alle Filterkriterien müssen erfüllt sein, damit eine Aufgabe angezeigt wird", "requireAll": "Alle Filterkriterien müssen erfüllt sein, damit eine Aufgabe angezeigt wird",
"showDoneTasks": "Erledigte Aufgaben anzeigen", "showDoneTasks": "Erledigte Aufgaben anzeigen",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Filter nach Priorität aktivieren", "enablePriority": "Filter nach Priorität aktivieren",
"enablePercentDone": "Filter nach % Erledigt aktivieren", "enablePercentDone": "Filter nach % Erledigt aktivieren",
"dueDateRange": "Fälligkeitsbereich", "dueDateRange": "Fälligkeitsbereich",

View File

@ -373,7 +373,6 @@
"includeNulls": "Uufgabe ohni Wert iihbezieh", "includeNulls": "Uufgabe ohni Wert iihbezieh",
"requireAll": "Alli Filter mend wahr sii, demits die Uufgab ahzeigt", "requireAll": "Alli Filter mend wahr sii, demits die Uufgab ahzeigt",
"showDoneTasks": "Zeig die fertige Uufgabe", "showDoneTasks": "Zeig die fertige Uufgabe",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Filter nach Priorität aktiviere", "enablePriority": "Filter nach Priorität aktiviere",
"enablePercentDone": "Filter nach Prozent iihschalte", "enablePercentDone": "Filter nach Prozent iihschalte",
"dueDateRange": "Fälligkeitsberiich", "dueDateRange": "Fälligkeitsberiich",

View File

@ -373,7 +373,6 @@
"includeNulls": "Include Tasks which don't have a value set", "includeNulls": "Include Tasks which don't have a value set",
"requireAll": "Require all filters to be true for a task to show up", "requireAll": "Require all filters to be true for a task to show up",
"showDoneTasks": "Show Done Tasks", "showDoneTasks": "Show Done Tasks",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Enable Filter By Priority", "enablePriority": "Enable Filter By Priority",
"enablePercentDone": "Enable Filter By Percent Done", "enablePercentDone": "Enable Filter By Percent Done",
"dueDateRange": "Due Date Range", "dueDateRange": "Due Date Range",

View File

@ -373,7 +373,6 @@
"includeNulls": "Inclure les tâches sans valeurs", "includeNulls": "Inclure les tâches sans valeurs",
"requireAll": "Exiger tous les filtres pour quune tâche saffiche", "requireAll": "Exiger tous les filtres pour quune tâche saffiche",
"showDoneTasks": "Afficher les tâches terminées", "showDoneTasks": "Afficher les tâches terminées",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Activer le filtre par priorité", "enablePriority": "Activer le filtre par priorité",
"enablePercentDone": "Par % dachèvement", "enablePercentDone": "Par % dachèvement",
"dueDateRange": "Plage de dates déchéance", "dueDateRange": "Plage de dates déchéance",

View File

@ -373,7 +373,6 @@
"includeNulls": "Includi attività che non hanno un valore impostato", "includeNulls": "Includi attività che non hanno un valore impostato",
"requireAll": "Tutti i filtri devono essere veri affinché l'attività venga mostrata", "requireAll": "Tutti i filtri devono essere veri affinché l'attività venga mostrata",
"showDoneTasks": "Mostra Attività Fatte", "showDoneTasks": "Mostra Attività Fatte",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Abilita Filtro Per Priorità", "enablePriority": "Abilita Filtro Per Priorità",
"enablePercentDone": "Abilitare Filtro Per Percentuale Fatta", "enablePercentDone": "Abilitare Filtro Per Percentuale Fatta",
"dueDateRange": "Intervallo Data Di Scadenza", "dueDateRange": "Intervallo Data Di Scadenza",

View File

@ -373,7 +373,6 @@
"includeNulls": "Include Tasks which don't have a value set", "includeNulls": "Include Tasks which don't have a value set",
"requireAll": "Require all filters to be true for a task to show up", "requireAll": "Require all filters to be true for a task to show up",
"showDoneTasks": "Show Done Tasks", "showDoneTasks": "Show Done Tasks",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Enable Filter By Priority", "enablePriority": "Enable Filter By Priority",
"enablePercentDone": "Enable Filter By Percent Done", "enablePercentDone": "Enable Filter By Percent Done",
"dueDateRange": "Due Date Range", "dueDateRange": "Due Date Range",

View File

@ -373,7 +373,6 @@
"includeNulls": "Include Tasks which don't have a value set", "includeNulls": "Include Tasks which don't have a value set",
"requireAll": "Require all filters to be true for a task to show up", "requireAll": "Require all filters to be true for a task to show up",
"showDoneTasks": "Show Done Tasks", "showDoneTasks": "Show Done Tasks",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Enable Filter By Priority", "enablePriority": "Enable Filter By Priority",
"enablePercentDone": "Enable Filter By Percent Done", "enablePercentDone": "Enable Filter By Percent Done",
"dueDateRange": "Due Date Range", "dueDateRange": "Due Date Range",

View File

@ -373,7 +373,6 @@
"includeNulls": "Include Tasks which don't have a value set", "includeNulls": "Include Tasks which don't have a value set",
"requireAll": "Require all filters to be true for a task to show up", "requireAll": "Require all filters to be true for a task to show up",
"showDoneTasks": "Show Done Tasks", "showDoneTasks": "Show Done Tasks",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Enable Filter By Priority", "enablePriority": "Enable Filter By Priority",
"enablePercentDone": "Enable Filter By Percent Done", "enablePercentDone": "Enable Filter By Percent Done",
"dueDateRange": "Due Date Range", "dueDateRange": "Due Date Range",

View File

@ -373,7 +373,6 @@
"includeNulls": "Include Tasks which don't have a value set", "includeNulls": "Include Tasks which don't have a value set",
"requireAll": "Require all filters to be true for a task to show up", "requireAll": "Require all filters to be true for a task to show up",
"showDoneTasks": "Show Done Tasks", "showDoneTasks": "Show Done Tasks",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Enable Filter By Priority", "enablePriority": "Enable Filter By Priority",
"enablePercentDone": "Enable Filter By Percent Done", "enablePercentDone": "Enable Filter By Percent Done",
"dueDateRange": "Due Date Range", "dueDateRange": "Due Date Range",

View File

@ -373,7 +373,6 @@
"includeNulls": "Включать задачи, у которых не установлено значение", "includeNulls": "Включать задачи, у которых не установлено значение",
"requireAll": "Для отображения задачи требовать истинность всех фильтров", "requireAll": "Для отображения задачи требовать истинность всех фильтров",
"showDoneTasks": "Показывать завершённые задачи", "showDoneTasks": "Показывать завершённые задачи",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Вкл. фильтр по приоритету", "enablePriority": "Вкл. фильтр по приоритету",
"enablePercentDone": "По % завершения", "enablePercentDone": "По % завершения",
"dueDateRange": "Диапазон срока", "dueDateRange": "Диапазон срока",

View File

@ -373,7 +373,6 @@
"includeNulls": "Include Tasks which don't have a value set", "includeNulls": "Include Tasks which don't have a value set",
"requireAll": "Require all filters to be true for a task to show up", "requireAll": "Require all filters to be true for a task to show up",
"showDoneTasks": "Show Done Tasks", "showDoneTasks": "Show Done Tasks",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Enable Filter By Priority", "enablePriority": "Enable Filter By Priority",
"enablePercentDone": "Enable Filter By Percent Done", "enablePercentDone": "Enable Filter By Percent Done",
"dueDateRange": "Due Date Range", "dueDateRange": "Due Date Range",

View File

@ -373,7 +373,6 @@
"includeNulls": "Include Tasks which don't have a value set", "includeNulls": "Include Tasks which don't have a value set",
"requireAll": "Require all filters to be true for a task to show up", "requireAll": "Require all filters to be true for a task to show up",
"showDoneTasks": "Show Done Tasks", "showDoneTasks": "Show Done Tasks",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Enable Filter By Priority", "enablePriority": "Enable Filter By Priority",
"enablePercentDone": "Enable Filter By Percent Done", "enablePercentDone": "Enable Filter By Percent Done",
"dueDateRange": "Due Date Range", "dueDateRange": "Due Date Range",

View File

@ -373,7 +373,6 @@
"includeNulls": "Bao gồm các Công việc không có bộ giá trị", "includeNulls": "Bao gồm các Công việc không có bộ giá trị",
"requireAll": "Yêu cầu tất cả các bộ lọc phải đúng để một công việc được hiển thị", "requireAll": "Yêu cầu tất cả các bộ lọc phải đúng để một công việc được hiển thị",
"showDoneTasks": "Hiển thị các công việc đã hoàn thành", "showDoneTasks": "Hiển thị các công việc đã hoàn thành",
"sortAlphabetically": "Sort Alphabetically",
"enablePriority": "Bật Bộ lọc theo mức độ ưu tiên", "enablePriority": "Bật Bộ lọc theo mức độ ưu tiên",
"enablePercentDone": "Bật Bộ lọc theo tỉ lệ % hoàn thành", "enablePercentDone": "Bật Bộ lọc theo tỉ lệ % hoàn thành",
"dueDateRange": "Phạm vi ngày đến hạn", "dueDateRange": "Phạm vi ngày đến hạn",

View File

@ -261,11 +261,6 @@ export default {
this.$refs.newTaskInput.$refs.newTaskInput.focus() this.$refs.newTaskInput.$refs.newTaskInput.focus()
}, },
updateTaskList() { updateTaskList() {
// const tasks = [
// task,
// ...this.tasks,
// ]
// this.tasks = tasks
this.$store.commit(HAS_TASKS, true) this.$store.commit(HAS_TASKS, true)
this.reloadTasksWithCurrentFilterAndSorting() this.reloadTasksWithCurrentFilterAndSorting()
}, },