From 429b8a1ec48bff67d7dec0988e7b8ab5e325f3b0 Mon Sep 17 00:00:00 2001 From: kolaente Date: Thu, 29 Sep 2022 18:23:07 +0200 Subject: [PATCH] chore: use amount const in tests --- src/helpers/defaultReminder.test.ts | 9 +++++---- src/helpers/defaultReminder.ts | 7 ++++++- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/helpers/defaultReminder.test.ts b/src/helpers/defaultReminder.test.ts index 6fbc117b3..d6f4793ec 100644 --- a/src/helpers/defaultReminder.test.ts +++ b/src/helpers/defaultReminder.test.ts @@ -1,5 +1,6 @@ import {describe, it, expect, vi, afterEach, beforeEach} from 'vitest' import { + AMOUNTS_IN_SECONDS, getDefaultReminderSettings, getSavedReminderSettings, parseSavedReminderAmount, @@ -36,25 +37,25 @@ describe('Default Reminder Save', () => { describe('Default Reminder Load', () => { it('Should parse minutes', () => { - const settings = parseSavedReminderAmount(5 * 60) + const settings = parseSavedReminderAmount(5 * AMOUNTS_IN_SECONDS.minutes) expect(settings.amount).toBe(5) expect(settings.type).toBe('minutes') }) it('Should parse hours', () => { - const settings = parseSavedReminderAmount(5 * 60 * 60) + const settings = parseSavedReminderAmount(5 * AMOUNTS_IN_SECONDS.hours) expect(settings.amount).toBe(5) expect(settings.type).toBe('hours') }) it('Should parse days', () => { - const settings = parseSavedReminderAmount(5 * 60 * 60 * 24) + const settings = parseSavedReminderAmount(5 * AMOUNTS_IN_SECONDS.days) expect(settings.amount).toBe(5) expect(settings.type).toBe('days') }) it('Should parse months', () => { - const settings = parseSavedReminderAmount(5 * 60 * 60 * 24 * 30) + const settings = parseSavedReminderAmount(5 * AMOUNTS_IN_SECONDS.months) expect(settings.amount).toBe(5) expect(settings.type).toBe('months') diff --git a/src/helpers/defaultReminder.ts b/src/helpers/defaultReminder.ts index 66e604ae6..98a2de845 100644 --- a/src/helpers/defaultReminder.ts +++ b/src/helpers/defaultReminder.ts @@ -1,6 +1,11 @@ const DEFAULT_REMINDER_KEY = 'defaultReminder' -const AMOUNTS_IN_SECONDS: { [key: string]: number } = { +export const AMOUNTS_IN_SECONDS: { + minutes: number, + hours: number, + days: number, + months: number, +} = { minutes: 60, hours: 60 * 60, days: 60 * 60 * 24,