vikunja/frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

chore: inline simple helper
All checks were successful
continuous-integration/drone/pr Build is passing
Details

Browse Source
This commit is contained in:
Dominik Pschenitschni 2022-11-03 17:48:59 +01:00
parent 8b7b4d61a3
commit c4a9c47203
Signed by: dpschen
GPG Key ID: B257AC0149F43A77
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/helpers/objectIsEmpty.ts
View File

@ -1,6 +0,0 @@
// https://stackoverflow.com/a/32108184/10924593
export function objectIsEmpty(obj: Record<string, unknown>): boolean {
return obj
&& Object.keys(obj).length === 0
&& Object.getPrototypeOf(obj) === Object.prototype
}

5
src/views/user/settings/General.vue
View File

@ -162,7 +162,6 @@ import {SUPPORTED_LOCALES} from '@/i18n'
import {playSoundWhenDoneKey, playPopSound} from '@/helpers/playPop' import {playSoundWhenDoneKey, playPopSound} from '@/helpers/playPop'
import {getQuickAddMagicMode, setQuickAddMagicMode} from '@/helpers/quickAddMagicMode' import {getQuickAddMagicMode, setQuickAddMagicMode} from '@/helpers/quickAddMagicMode'
import {createRandomID} from '@/helpers/randomId' import {createRandomID} from '@/helpers/randomId'
import {objectIsEmpty} from '@/helpers/objectIsEmpty'
import {success} from '@/message' import {success} from '@/message'
import {AuthenticatedHTTPFactory} from '@/helpers/fetcher' import {AuthenticatedHTTPFactory} from '@/helpers/fetcher'
@ -235,8 +234,8 @@ const availableLanguageOptions = ref(
watch( watch(
() => authStore.settings, () => authStore.settings,
() => { () => {
// Only setting if we don't have values set yet to avoid overriding edited values // Only set setting if we don't have edited values yet to avoid overriding
if (!objectIsEmpty(settings.value)) { if (Object.keys(settings.value).length !== 0) {
return return
} }
settings.value = {...authStore.settings} settings.value = {...authStore.settings}