feat: add FIXME comments
All checks were successful
continuous-integration/drone/pr Build is passing

This commit is contained in:
Dominik Pschenitschni 2021-10-18 14:33:59 +02:00
parent 38a42fd242
commit e70d6484f8
Signed by: dpschen
GPG Key ID: B257AC0149F43A77
10 changed files with 46 additions and 0 deletions

View File

@ -1,3 +1,4 @@
// FIXME: adapt lables.vue so that it can be used for this aswell
.labels-list { .labels-list {
a, a:hover { a, a:hover {
text-decoration: none; text-decoration: none;
@ -7,6 +8,7 @@
margin: .5rem 0 .5rem .5rem; margin: .5rem 0 .5rem .5rem;
background: $grey-200; background: $grey-200;
// FIXME: only used in ListLabels.vue
&.disabled { &.disabled {
opacity: 0.7; opacity: 0.7;

View File

@ -1,3 +1,10 @@
// FIXME: should be a component <FilterContainer>
// used in
// - gantt-component.vue
// - Kanban.vue
// - List.vue
// - Table.vue
$filter-container-top-default: -59px; $filter-container-top-default: -59px;
$filter-container-top-link-share-gantt: -138px; $filter-container-top-link-share-gantt: -138px;
$filter-container-top-link-share-list: -47px; $filter-container-top-link-share-list: -47px;

View File

@ -1,3 +1,4 @@
// FIXME: used in navigation.vue and in ListNamespaces.vue
.namespaces-list.loader-container.is-loading { .namespaces-list.loader-container.is-loading {
min-height: calc(100vh - #{$navbar-height + 1.5rem + 1rem + 1.5rem}); min-height: calc(100vh - #{$navbar-height + 1.5rem + 1rem + 1.5rem});
} }

View File

@ -1,7 +1,14 @@
// FIXME: should be in TaskDetailView.vue
.link-share-container:not(.has-background) .task-view { .link-share-container:not(.has-background) .task-view {
background: transparent; background: transparent;
} }
// FIXME: create <Done> component
// used in
// - heading.vue
// - kanban-card.vue
// - Kanban.vue
// - Table.vue
.is-done { .is-done {
background: $green; background: $green;
color: $white; color: $white;
@ -14,6 +21,7 @@
text-align: center; text-align: center;
} }
// FIXME: should be a prop of TaskDetailView.vue
.modal-container .task-view { .modal-container .task-view {
border-radius: $radius; border-radius: $radius;
padding: 1rem; padding: 1rem;

View File

@ -1,3 +1,6 @@
// FIXME: These classes are used all over.
// very hard to untangle
// they have many overwrites at different positions
.tasks { .tasks {
margin-top: 1rem; margin-top: 1rem;
padding: 0; padding: 0;
@ -43,6 +46,9 @@
} }
// FIXME: seems only necessary for
// - relatedTasks.vue
// - singleTaskInList.vue
.is-menu-enabled .tasks .task { .is-menu-enabled .tasks .task {
span:not(.tag), a { span:not(.tag), a {
.tasktext, .tasktext,
@ -60,6 +66,10 @@
} }
} }
// FIXME: is only used where <edit-task> is used aswell:
// - gantt-component.vue
// - List.vue
// -> Move the <card> wrapper including this class definition inside <edit-task>
.is-max-width-desktop .tasks .task { .is-max-width-desktop .tasks .task {
max-width: $desktop; max-width: $desktop;
} }

View File

@ -1,3 +1,5 @@
// FIXME: https://www.bram.us/2021/09/13/dont-attach-tooltips-to-document-body/
.tooltip { .tooltip {
visibility: collapse; visibility: collapse;
z-index: 10000; z-index: 10000;

View File

@ -1,3 +1,8 @@
// FIXME:
// this should be moved to button.vue
// what prevents this currently is that the class is also used
// on a <select> element in userTeam.vue
// -> Maybe create a mixin and import in both components?
.button { .button {
transition: all $transition; transition: all $transition;
border: 0; border: 0;
@ -105,6 +110,9 @@
margin-right: 0.05rem !important; margin-right: 0.05rem !important;
} }
// FIXME: used for
// - the <h1> in heading.vue
// - the <h2> in Kanban.vue
// Contenteditable form // Contenteditable form
.input.title { .input.title {
font-size: 1.8rem; font-size: 1.8rem;

View File

@ -1,3 +1,4 @@
// FIXME: move to loading.vue
.loader-container.is-loading { .loader-container.is-loading {
position: relative; position: relative;
pointer-events: none; pointer-events: none;
@ -14,6 +15,7 @@
} }
} }
// FIXME: move to ShowTasks.vue
.spinner.is-loading { .spinner.is-loading {
pointer-events: none; pointer-events: none;

View File

@ -1,3 +1,5 @@
// FIXME: create <MenuButton> component
.menu-hide-button, .menu-hide-button,
.menu-show-button { .menu-show-button {
display: none; display: none;

View File

@ -64,6 +64,7 @@ h6 {
} }
} }
// FIXME: these helpers should be mixins
.has-no-border { .has-no-border {
border: none !important; border: none !important;
} }
@ -81,6 +82,7 @@ h6 {
overflow-x: auto; overflow-x: auto;
} }
// FIXME: this should be moved in a Avatar component
.image.is-avatar { .image.is-avatar {
border-radius: 100%; border-radius: 100%;
} }
@ -89,6 +91,8 @@ button.table {
margin-bottom: 0 !important; margin-bottom: 0 !important;
} }
// FIXME: merge with dropdown-item.vue
// for this to happen the component has to be used everywhere
.dropdown-item { .dropdown-item {
display: flex; display: flex;
align-items: center; align-items: center;