fix: improve some types

Reviewed-on: #2220
Co-authored-by: renovate <renovatebot@kolaente.de>
Co-committed-by: renovate <renovatebot@kolaente.de>

README.md

@@ -4,7 +4,7 @@
 
 [![Build Status](https://drone.kolaente.de/api/badges/vikunja/frontend/status.svg)](https://drone.kolaente.de/vikunja/frontend)
 [![License: AGPL v3](https://img.shields.io/badge/License-AGPL%20v3-blue.svg)](LICENSE)
-[![Download](https://img.shields.io/badge/download-v0.18.2-brightgreen.svg)](https://dl.vikunja.io)
+[![Download](https://img.shields.io/badge/download-v0.19.0-brightgreen.svg)](https://dl.vikunja.io)
 [![Translation](https://badges.crowdin.net/vikunja/localized.svg)](https://crowdin.com/project/vikunja)
 
 This is the web frontend for Vikunja, written in Vue.js.

cliff.toml

@@ -0,0 +1,59 @@
+[changelog]
+body = """
+{% if version %}\
+    ## [{{ version | trim_start_matches(pat="v") }}] - {{ timestamp | date(format="%Y-%m-%d") }}
+{% else %}\
+    ## [unreleased]
+{% endif %}\
+
+
+{% for group, commits in commits | group_by(attribute="group") %}
+    ### {{ group | upper_first }}
+    {% for commit in commits
+    | filter(attribute="scope")
+    | sort(attribute="scope") %}
+        * *({{commit.scope}})* {{ commit.message | upper_first }}
+        {%- if commit.breaking %}
+        {% raw %}  {% endraw %}- **BREAKING**: {{commit.breaking_description}}
+        {%- endif -%}
+    {%- endfor -%}
+    {%- for commit in commits %}
+        {%- if commit.scope -%}
+        {% else -%}
+            * {{ commit.message | upper_first }} ([{{ commit.id | truncate(length=7, end="") }}]({{ commit.id }}))
+            {% if commit.breaking -%}
+            {% raw %}  {% endraw %}- **BREAKING**: {{commit.breaking_description}}
+            {% endif -%}
+        {% endif -%}
+    {% endfor -%}
+    {% raw %}\n{% endraw %}\
+{% endfor %}\n
+
+"""
+#{% for group, commits in commits | group_by(attribute="group") %}
+#    ### {{ group | upper_first }}
+#    {% for commit in commits %}\
+#        - {% if commit.breaking %}[**breaking**] {% endif %}{{ commit.message | upper_first }} ([{{ commit.id | truncate(length=7, end="") }}]({{ commit.id }}))
+#    {% endfor %}\
+#{% endfor %}\n
+# remove the leading and trailing whitespace from the template
+trim = true
+
+[git]
+conventional_commits = true
+filter_unconventional = false
+commit_parsers = [
+    { message = ".*(deps).*", group = "Dependencies"},
+    { message = "^feat", group = "Features"},
+    { message = "^fix", group = "Bug Fixes"},
+    { message = "^doc", group = "Documentation"},
+    { message = "^perf", group = "Performance"},
+    { message = "^refactor", group = "Refactor"},
+    { message = "^style", group = "Styling"},
+    { message = "^test", group = "Testing"},
+    { message = "^chore\\(release\\): prepare for", skip = true},
+    { message = "^chore", group = "Miscellaneous Tasks"},
+    { body = ".*security", group = "Security"},
+    { message = ".*", group = "Other", default_scope = "other"}, # Everything that's not a conventional commit goes into the "Other" category
+]
+

package.json

@@ -19,18 +19,18 @@
   },
   "dependencies": {
     "@github/hotkey": "2.0.1",
-    "@kyvg/vue3-notification": "2.3.5",
-    "@sentry/tracing": "7.7.0",
-    "@sentry/vue": "7.7.0",
+    "@kyvg/vue3-notification": "2.3.6",
+    "@sentry/tracing": "7.8.1",
+    "@sentry/vue": "7.8.1",
     "@types/is-touch-device": "1.0.0",
     "@types/lodash.clonedeep": "^4.5.7",
     "@types/sortablejs": "1.13.0",
-    "@vueuse/core": "8.9.4",
-    "@vueuse/router": "8.9.4",
+    "@vueuse/core": "9.1.0",
+    "@vueuse/router": "9.1.0",
     "blurhash": "1.1.5",
     "bulma-css-variables": "0.9.33",
     "camel-case": "4.1.2",
-    "date-fns": "2.28.0",
+    "date-fns": "2.29.1",
     "dompurify": "2.3.10",
     "easymde": "2.16.1",
     "flatpickr": "4.6.13",
@@ -49,10 +49,10 @@
     "vue-advanced-cropper": "2.8.3",
     "vue-drag-resize": "2.0.3",
     "vue-flatpickr-component": "9.0.6",
-    "vue-i18n": "9.2.0-beta.40",
-    "vue-router": "4.1.2",
+    "vue-i18n": "9.2.0",
+    "vue-router": "4.1.3",
     "vuex": "4.0.2",
-    "workbox-precaching": "6.5.3",
+    "workbox-precaching": "6.5.4",
     "zhyswan-vuedraggable": "4.1.3"
   },
   "devDependencies": {
@@ -60,42 +60,42 @@
     "@cypress/vite-dev-server": "3.0.0",
     "@cypress/vue": "4.0.0",
     "@faker-js/faker": "7.3.0",
-    "@fortawesome/fontawesome-svg-core": "6.1.1",
-    "@fortawesome/free-regular-svg-icons": "6.1.1",
-    "@fortawesome/free-solid-svg-icons": "6.1.1",
+    "@fortawesome/fontawesome-svg-core": "6.1.2",
+    "@fortawesome/free-regular-svg-icons": "6.1.2",
+    "@fortawesome/free-solid-svg-icons": "6.1.2",
     "@fortawesome/vue-fontawesome": "3.0.1",
     "@types/flexsearch": "0.7.3",
-    "@typescript-eslint/eslint-plugin": "5.30.7",
-    "@typescript-eslint/parser": "5.30.7",
+    "@typescript-eslint/eslint-plugin": "5.32.0",
+    "@typescript-eslint/parser": "5.32.0",
     "@vitejs/plugin-legacy": "2.0.0",
     "@vitejs/plugin-vue": "3.0.1",
     "@vue/eslint-config-typescript": "11.0.0",
     "@vue/test-utils": "2.0.2",
     "@vue/tsconfig": "0.1.3",
-    "autoprefixer": "10.4.7",
+    "autoprefixer": "10.4.8",
     "axios": "0.27.2",
-    "browserslist": "4.21.1",
-    "caniuse-lite": "1.0.30001363",
-    "cypress": "10.3.1",
-    "esbuild": "0.14.49",
-    "eslint": "8.20.0",
-    "eslint-plugin-vue": "9.2.0",
+    "browserslist": "4.21.3",
+    "caniuse-lite": "1.0.30001373",
+    "cypress": "10.4.0",
+    "esbuild": "0.14.53",
+    "eslint": "8.21.0",
+    "eslint-plugin-vue": "9.3.0",
     "express": "4.18.1",
     "happy-dom": "6.0.4",
-    "netlify-cli": "10.9.0",
+    "netlify-cli": "10.13.0",
     "postcss": "8.4.14",
     "postcss-preset-env": "7.7.2",
-    "rollup": "2.77.0",
+    "rollup": "2.77.2",
     "rollup-plugin-visualizer": "5.7.1",
-    "sass": "1.53.0",
+    "sass": "1.54.2",
     "typescript": "4.7.4",
-    "vite": "3.0.2",
+    "vite": "3.0.4",
     "vite-plugin-pwa": "0.12.3",
     "vite-svg-loader": "3.4.0",
-    "vitest": "0.18.1",
-    "vue-tsc": "0.38.9",
+    "vitest": "0.20.3",
+    "vue-tsc": "0.39.4",
     "wait-on": "6.0.1",
-    "workbox-cli": "6.5.3"
+    "workbox-cli": "6.5.4"
   },
   "postcss": {
     "plugins": {

src/components/sharing/userTeam.vue

@@ -137,7 +137,7 @@ export default {name: 'userTeamShare'}
 </script>
 
 <script setup lang="ts">
-import {ref, reactive, computed, shallowReactive, type ShallowReactive, type Ref} from 'vue'
+import {ref, reactive, computed, shallowReactive, type Ref} from 'vue'
 import type {PropType} from 'vue'
 import {useStore} from '@/store'
 import {useI18n} from 'vue-i18n'

src/components/tasks/edit-task.vue

@@ -95,8 +95,7 @@ const router = useRouter()
 
 const props = defineProps({
 	task: {
-		type: Object as PropType<ITask>,
-		required: true,
+		type: Object as PropType<ITask | null>,
 	},
 })
 

src/components/tasks/partials/singleTaskInList.vue

@@ -30,7 +30,7 @@
 				{{ task.title }}
 			</span>
 
-			<labels class="labels ml-2 mr-1" :labels="task.labels" v-if="task.labels.length > 0"/>
+			<labels class="labels ml-2 mr-1" :labels="task.labels" v-if="task.labels.length > 0" />
 			<user
 				:avatar-size="27"
 				:is-inline="true"
@@ -96,11 +96,13 @@
 </template>
 
 <script lang="ts">
-import {defineComponent} from 'vue'
+import {defineComponent, type PropType} from 'vue'
 
 import TaskModel, { type ITask } from '../../../models/task'
 import PriorityLabel from './priorityLabel.vue'
 import TaskService from '../../../services/task'
+import Labels from '@/components/tasks/partials/labels.vue'
+import User from '@/components/misc/user.vue'
 import BaseButton from '@/components/base/BaseButton.vue'
 import Fancycheckbox from '../../input/fancycheckbox.vue'
 import DeferTask from './defer-task.vue'

src/helpers/parseDateOrNull.ts

@@ -1,13 +1,14 @@
 /**
  * Make date objects from timestamps
-*/
+ */
 export function parseDateOrNull(date) {
 	if (date instanceof Date) {
 		return date
 	}
 
-	if (date && !date.startsWith('0001')) {
+	if ((typeof date === 'string' || date instanceof String) && !date.startsWith('0001')) {
 		return new Date(date)
 	}
+
 	return null
 }

src/i18n/lang/ca-ES.json

@@ -780,7 +780,8 @@
       "days": "Days",
       "weeks": "Weeks",
       "months": "Months",
-      "years": "Years"
+      "years": "Years",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "You can use Quick Add Magic",

src/i18n/lang/cs-CZ.json

@@ -780,7 +780,8 @@
       "days": "Dnů",
       "weeks": "Týdny",
       "months": "Měsíce",
-      "years": "Roky"
+      "years": "Roky",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "Můžeš použít Kouzelné rychlé přidání",

src/i18n/lang/de-DE.json

@@ -780,7 +780,8 @@
       "days": "Tage",
       "weeks": "Wochen",
       "months": "Monate",
-      "years": "Jahre"
+      "years": "Jahre",
+      "invalidAmount": "Bitte mehr als 0 eingeben."
     },
     "quickAddMagic": {
       "hint": "Du kannst Quick Add Magic verwenden",

src/i18n/lang/de-swiss.json

@@ -780,7 +780,8 @@
       "days": "Tääg",
       "weeks": "Wuchä",
       "months": "Monet",
-      "years": "Jahr"
+      "years": "Jahr",
+      "invalidAmount": "Bitte mehr als 0 eingeben."
     },
     "quickAddMagic": {
       "hint": "Du chasch Quick Add Magic verwendä",

src/i18n/lang/es-ES.json

@@ -780,7 +780,8 @@
       "days": "Days",
       "weeks": "Weeks",
       "months": "Months",
-      "years": "Years"
+      "years": "Years",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "You can use Quick Add Magic",

src/i18n/lang/fr-FR.json

@@ -780,7 +780,8 @@
       "days": "Jours",
       "weeks": "Semaines",
       "months": "Mois",
-      "years": "Années"
+      "years": "Années",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "Tu peux utiliser Quick Add Magic",

src/i18n/lang/it-IT.json

@@ -780,7 +780,8 @@
       "days": "Giorni",
       "weeks": "Settimane",
       "months": "Mesi",
-      "years": "Anni"
+      "years": "Anni",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "Puoi usare l'Aggiunta Rapida Magica",

src/i18n/lang/nl-NL.json

@@ -780,7 +780,8 @@
       "days": "Dagen",
       "weeks": "Weken",
       "months": "Maanden",
-      "years": "Jaren"
+      "years": "Jaren",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "You can use Quick Add Magic",

src/i18n/lang/pl-PL.json

@@ -780,7 +780,8 @@
       "days": "Dni",
       "weeks": "Tygodnie",
       "months": "Miesiące",
-      "years": "Lata"
+      "years": "Lata",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "Możesz użyć Quick Add Magic",

src/i18n/lang/pt-BR.json

@@ -780,7 +780,8 @@
       "days": "Days",
       "weeks": "Weeks",
       "months": "Months",
-      "years": "Years"
+      "years": "Years",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "You can use Quick Add Magic",

src/i18n/lang/pt-PT.json

@@ -780,7 +780,8 @@
       "days": "Dias",
       "weeks": "Semanas",
       "months": "Meses",
-      "years": "Anos"
+      "years": "Anos",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "Podes utilizar a Introdução Mágica Rápida",

src/i18n/lang/ro-RO.json

@@ -780,7 +780,8 @@
       "days": "Days",
       "weeks": "Weeks",
       "months": "Months",
-      "years": "Years"
+      "years": "Years",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "You can use Quick Add Magic",

src/i18n/lang/ru-RU.json

@@ -780,7 +780,8 @@
       "days": "Дней",
       "weeks": "Недель",
       "months": "Месяцев",
-      "years": "Лет"
+      "years": "Лет",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "Вы можете использовать Волшебное Быстрое Добавление",

src/i18n/lang/sk-SK.json

@@ -780,7 +780,8 @@
       "days": "Days",
       "weeks": "Weeks",
       "months": "Months",
-      "years": "Years"
+      "years": "Years",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "You can use Quick Add Magic",

src/i18n/lang/sv-SE.json

@@ -780,7 +780,8 @@
       "days": "Days",
       "weeks": "Weeks",
       "months": "Months",
-      "years": "Years"
+      "years": "Years",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "You can use Quick Add Magic",

src/i18n/lang/tr-TR.json

@@ -780,7 +780,8 @@
       "days": "Days",
       "weeks": "Weeks",
       "months": "Months",
-      "years": "Years"
+      "years": "Years",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "You can use Quick Add Magic",

src/i18n/lang/vi-VN.json

@@ -780,7 +780,8 @@
       "days": "Ngày",
       "weeks": "Tuần",
       "months": "Tháng",
-      "years": "Năm"
+      "years": "Năm",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "Bạn có thể sử dụng Quick Add Magic",

src/modules/parseTaskText.test.ts

@@ -314,6 +314,42 @@ describe('Parse Task Text', () => {
 			expect(result.text).toBe('Lorem Ipsum github')
 			expect(result.date).toBeNull()
 		})
+		describe('Should not recognize weekdays in words', () => {
+			const cases = [
+				'renewed',
+				'github',
+				'fix monitor stand',
+				'order wedding cake',
+				'investigate thumping noise',
+				'iron frilly napkins',
+				'take photo of saturn',
+				'fix sunglasses',
+				'monitor blood pressure',
+				'Monitor blood pressure',
+				'buy almonds',
+			]
+
+			cases.forEach(c => {
+				it(`should not recognize text with ${c} at the beginning as weekday`, () => {
+					const result = parseTaskText(`${c} dolor sit amet`)
+
+					expect(result.text).toBe(`${c} dolor sit amet`)
+					expect(result.date).toBeNull()
+				})
+				it(`should not recognize text with ${c} at the end as weekday`, () => {
+					const result = parseTaskText(`Lorem Ipsum ${c}`)
+
+					expect(result.text).toBe(`Lorem Ipsum ${c}`)
+					expect(result.date).toBeNull()
+				})
+				it(`should not recognize text with ${c} as weekday`, () => {
+					const result = parseTaskText(`Lorem Ipsum ${c} dolor`)
+
+					expect(result.text).toBe(`Lorem Ipsum ${c} dolor`)
+					expect(result.date).toBeNull()
+				})
+			})
+		})
 		it('should not recognize date number with no spacing around them', () => {
 			const result = parseTaskText('Lorem Ispum v1.1.1')
 

src/styles/custom-properties/colors.scss

@@ -245,6 +245,7 @@
   --border: var(--grey-200);
   --input-disabled-background-color: var(--grey-100);
   --input-disabled-border-color: var(--grey-300);
+  --progress-value-background-color: var(--grey-500);
   // END Overrides of Bulma defaults
 
 
@@ -286,7 +287,7 @@
       // Elements that rely on Bulma defaults in light mode but
       // need to be overriden in dark mode
       --input-placeholder-color: hsla(var(--grey-900-hsl), 0.6);
-      --tag-color: var(--grey-800);
+      --tag-color: var(--grey-300);
       --table-row-hover-background-color: var(--grey-100);
       --dropdown-item-hover-background-color: var(--grey-100);
       --dropdown-item-hover-color: var(--text);

src/styles/theme/theme.scss

@@ -52,11 +52,6 @@ h6 {
 	margin: 0 0.5rem 0 0;
 	flex: 3 1 auto;
 
-	&::-moz-progress-bar,
-	&::-webkit-progress-value {
-	  background: var(--grey-500);
-	}
-
 	@media screen and (max-width: $tablet) {
 		margin: 0.5rem 0 0 0;
 		order: 1;

src/sw.ts

@@ -1,7 +1,7 @@
 /* eslint-disable no-console */
 /* eslint-disable no-undef */
 
-const workboxVersion = 'v6.5.3'
+const workboxVersion = 'v6.5.4'
 importScripts( `/workbox-${workboxVersion}/workbox-sw.js`)
 workbox.setConfig({
 	modulePathPrefix: `/workbox-${workboxVersion}`,

src/views/list/ListList.vue

@@ -289,19 +289,9 @@ export default defineComponent({
 			this.$store.commit(HAS_TASKS, true)
 		},
 		editTask(id: ITask['id']) {
-			// Find the selected task and set it to the current object
-			let theTask = this.getTaskById(id) // Somehow this does not work if we directly assign this to this.taskEditTask
-			this.taskEditTask = theTask
+			this.taskEditTask = {...this.tasks.find(t => t.id === parseInt(id))}
 			this.isTaskEdit = true
 		},
-		getTaskById(id: ITask['id']) {
-			for (const t in this.tasks) {
-				if (this.tasks[t].id === parseInt(id)) {
-					return this.tasks[t]
-				}
-			}
-			return {} // FIXME: This should probably throw something to make it clear to the user noting was found
-		},
 		updateTasks(updatedTask: ITask) {
 			for (const t in this.tasks) {
 				if (this.tasks[t].id === updatedTask.id) {