time fields in calendar widget don't update unless you click away first #1904

New Issue

Ghost · 2022-02-09T15:15:34Z

Ghost commented

2022-02-09 15:15:34 +00:00

In any place where the calendar view shows up (e.g. deferring from list view, editing the due date from task detail, or modifying the ranges in "Upcoming"), when I edit the time I have to click away from either the hours or the minutes in order for it to actually update. So if I type 23<Tab>30 and then click "confirm", it only saves the hours and not the minutes. But if I click on the hours again and then click "confirm" it saves both fields.

In any place where the calendar view shows up (e.g. deferring from list view, editing the due date from task detail, or modifying the ranges in "Upcoming"), when I edit the time I have to click away from either the hours or the minutes in order for it to actually update. So if I type `23<Tab>30` and then click "confirm", it only saves the hours and not the minutes. But if I click on the hours again and then click "confirm" it saves both fields.

Ghost changed title from ~~time fields in calendar view don't update unless you click away first~~ to time fields in calendar widget don't update unless you click away first

2022-02-09 15:16:33 +00:00

konrad commented

2022-02-09 15:32:39 +00:00

I think that's an issue with the way the flatpickr component is set up in vue. Not sure if there's much we can do about that.

Ghost commented

2022-02-10 14:03:01 +00:00

Any chance you could point me upstream to where I can file a bug report on this? Seems like a common enough problem to want solved generally.

konrad commented

2022-02-10 22:08:05 +00:00

Sure! The component we're using is this one: https://github.com/ankurk91/vue-flatpickr-component

Feel free to ping me in any issues you create (@kolaente on github).

Sure! The component we're using is this one: https://github.com/ankurk91/vue-flatpickr-component Feel free to ping me in any issues you create (@kolaente on github).

Ghost commented

2022-02-10 22:49:04 +00:00

What versions of vue.js, flatpickr, and vue-flatpickr-component are we using?

Does it seem reasonable for me to use Vikunja to demonstrate the bug? I'm a little worried I won't be able to produce a MWE.

What versions of vue.js, flatpickr, and vue-flatpickr-component are we using? Does it seem reasonable for me to use Vikunja to demonstrate the bug? I'm a little worried I won't be able to produce a MWE.

konrad commented

2022-02-11 07:30:32 +00:00

All versions are here: https://kolaente.dev/vikunja/frontend/src/branch/main/package.json#L47

I think you can use Vikunja to demonstrate the bug. If they want a minimal reproducible version we can build one.

All versions are here: https://kolaente.dev/vikunja/frontend/src/branch/main/package.json#L47 I think you can use Vikunja to demonstrate the bug. If they want a minimal reproducible version we can build one.

konrad commented

2022-02-11 07:31:36 +00:00

Even better yet, the bug is reproducible in their demo: https://ankurk91.github.io/vue-flatpickr-component/

Ghost commented

2022-02-11 14:19:19 +00:00

Really? It's actually working for me there just fine.

konrad commented

2022-02-13 12:34:06 +00:00

Now that you say it... looks like it yes. Not quite sure how to proceed here.

@dpschen Do you have an idea?

Now that you say it... looks like it yes. Not quite sure how to proceed here. @dpschen Do you have an idea?

dpschen commented

2022-05-21 14:24:51 +00:00

Sorry for getting back so late. Somehow I missed this.
The vue-flatpickr-component is written really bad.
I want to replace it with a custom solution (because flatpickr itself is fine).

Sorry for getting back so late. Somehow I missed this. The vue-flatpickr-component is written really bad. I want to replace it with a custom solution (because flatpickr itself is fine).

👍 1

konrad referenced this issue from a commit

2024-02-07 14:00:34 +00:00

chore(deps): update dependency happy-dom to v3.1.1 (#1904)

Sign in to join this conversation.