pre blocks have light text on light background in dark mode #1915
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#1915
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Seeing this bug on a code block but the colour is applied via the pre element that wraps the code element.
Editing mode is fine but on save text becomes unreadable.
I assume this is another overlooked element that needs colour flipped for dark mode but haven't had a proper look yet.
Probably need to switch --pre-background to something darker.
This is replicateable on try.
I also note the pre background in light mode is an odd barely visible shade of grey.
It seems both both --pre and --pre-background are still using Bulma defaults (in light mode as well as dark) and need switched to something that fits with Vikunja colours (presumably one of the greys we already define).
I think switching the variables to one of the greys we already have is the way to go.
It's a different story when using code blocks with syntax highlighting like these:
The highlighting is powered by highlight.js which also includes the stylesheets. I don't think they have variants for dark modes.
Screenshots attached for '--background' set to '--grey--200' in light and dark.
How do we feel about that?
I think that's already better even if not perfect. But a lot more readable.
The lack of contrast in syntax highlight colours in dark mode is troubling me. Might need to do something separate for dark mode, a bit darker.
I'll whip up a pull request.
This appears to be fixed.