Confusing error messages when using faulty api url #1920

New Issue

dpschen · 2022-05-19T18:40:51Z

dpschen commented

2022-05-19 18:40:51 +00:00

Was testing this preview branch: https://1939-feature-feature-task-related-tas--vikunja-frontend-preview.netlify.app/

SCR-20220519-soc.png

249 KiB

dpschen added the

kind/bug

label 2022-05-19 18:40:51 +00:00

yksflip commented

2023-02-16 08:57:26 +00:00

I think this belongs here too:

When setting an api url without /api/v1 it looks like it would work, but it's actually not. This gives an false impression. (Should actually show up with sso login)

I think this belongs here too: When setting an api url without `/api/v1` it looks like it would work, but it's actually not. This gives an false impression. (Should actually show up with sso login) ![grafik](/attachments/75e18841-2c64-47c9-91fc-47090fcbd5ee)

grafik.png

844 KiB

grafik.png

844 KiB

konrad commented

2023-02-16 11:02:46 +00:00

@yksflip Your API is not reachable, that's why it won't show the sso login. (Vikunja should give you an error message in that case) The problem is not with the url having or not having the /api/v1 suffix in it.

@yksflip Your API is not reachable, that's why it won't show the sso login. (Vikunja should give you an error message in that case) The problem is not with the url having or not having the `/api/v1` suffix in it.

yksflip commented

2023-02-17 08:20:34 +00:00

upsi, I think when I took the screenshot it was actually reachable, after that I was fiddeling around with our deployment and broke it.

You can actually reproduce this on try.vikunja.io:

change the api domain to: https://try.vikunja.io/asdasda
get a positive notice
try to login
http error 405

what I'd expect:

change url to smth invalid
get error notice

upsi, I think when I took the screenshot it was actually reachable, after that I was fiddeling around with our deployment and broke it. You can actually reproduce this on try.vikunja.io: 1. change the api domain to: https://try.vikunja.io/asdasda 2. get a positive notice 3. try to login 4. http error 405 what I'd expect: 1. change url to smth invalid 2. get error notice

👍 1

konrad referenced this issue from a commit

2023-07-05 15:46:55 +00:00

feat: improve handling of an invalid api url

konrad closed this issue

2023-07-05 15:46:55 +00:00

konrad referenced this issue from a commit

2024-02-07 14:00:34 +00:00

chore(deps): update dependency vue-tsc to v0.34.12 (#1920)

Sign in to join this conversation.