Expose focus function from addTask #1924

New Issue

dpschen · 2022-05-22T21:29:39Z

dpschen commented

2022-05-22 21:29:39 +00:00

Because I get now:

When clicking on "Create new task" in an empty list.

Probably related to that in script setup nothing is exposed by default.

Because I get now: ![image](/attachments/3b904b9c-2323-4b7f-aac6-433b9fc8de98) When clicking on "Create new task" in an empty list. ![image](/attachments/41d2c790-8ccd-423f-92b5-5d11654555d9) Probably related to that in script setup nothing is exposed by default.

image.png

80 KiB

image.png

366 KiB

image.png

366 KiB

konrad added the

kind/bug

label 2022-05-23 05:16:56 +00:00

konrad referenced this issue from a commit

2022-05-23 20:34:04 +00:00

fix: properly reference task input textarea from parent component

konrad closed this issue

2022-05-23 20:34:04 +00:00

konrad commented

2022-05-23 20:35:01 +00:00

I've pushed a fix for this in 745d4660d8 - there's probably a better way to go about this, but this works just fine.

I've pushed a fix for this in https://kolaente.dev/vikunja/frontend/commit/745d4660d80c6eb00d682f70a283d1cebd8cba94 - there's probably a better way to go about this, but this works just fine.

dpschen commented

2022-05-23 20:56:18 +00:00

Yes :)

With the defineExpose helper from vue.

Yes :) With the `defineExpose` helper from vue.

👍 1

konrad reopened this issue

2022-05-23 21:17:25 +00:00

dpschen commented

2022-05-26 11:50:10 +00:00

Interestingly your fix also didn't seem to work, because there is a regression.

Not what I would have expected. Did you test this? Because from the error my guess is that refs are not exposed by default.

Interestingly your fix also didn't seem to work, because [there is a regression](https://sentry.io/organizations/vikunja/issues/3182616818/?project=6024480&referrer=regression_activity-email). Not what I would have expected. Did you test this? Because from the error my guess is that refs are not exposed by default.

konrad commented

2022-05-27 21:31:56 +00:00

I did test it, and it seems to work fine. I did not test this on chrome on firefox though.

But I guess the proper way to fix this would be to use defineExpose.

I did test it, and it seems to work fine. I did not test this on chrome on firefox though. But I guess the proper way to fix this would be to use `defineExpose`.

dpschen commented

2022-05-29 15:06:11 +00:00

I judt realise that this might have stoppef working again when we merged the "remove compability branch".

konrad referenced this issue from a commit

2022-06-17 12:26:04 +00:00

fix: properly define focus expose for new task input field

konrad closed this issue

2022-06-17 12:26:04 +00:00

konrad commented

2022-06-17 12:26:31 +00:00

Fixed again in e0864fab3e, this time properly 😀

Fixed again in https://kolaente.dev/vikunja/frontend/commit/e0864fab3eb7807b52eb0b0102b5ca5ef42366d1, this time properly 😀