Error: [vuex] do not mutate vuex store state outside mutation handlers #1945

New Issue

andreymal · 2022-07-15T17:01:19Z

andreymal commented

2022-07-15 17:01:19 +00:00

When editing some fields (including but not limited to: priority, date, progress, assignees) from the Kanban view (i.e. via task-detail-view-modal), the following error occurs:

Error: [vuex] do not mutate vuex store state outside mutation handlers.
    assert vuex.esm-bundler.js:83
    enableStrictMode vuex.esm-bundler.js:347
    // ...
    select multiselect.vue:294
    onClick multiselect.vue:47
    node_modules chunk-KQJ3BTR7.js:8799
    // ...
    node_modules chunk-KQJ3BTR7.js:1423
    // ...
    findLabel editLabels.vue:92
    // ...
    searchTimeout multiselect.vue:268
    setTimeout handler*search multiselect.vue:267
    // ...
    1 multiselect.vue:28

or:

Error: [vuex] do not mutate vuex store state outside mutation handlers.
    assert vuex.esm-bundler.js:83
    enableStrictMode vuex.esm-bundler.js:347
    // ...
    2 TaskDetailView.vue:44
    // ...
    updateData prioritySelect.vue:47

When editing some fields (including but not limited to: priority, date, progress, assignees) from the Kanban view (i.e. via `task-detail-view-modal`), the following error occurs: ``` Error: [vuex] do not mutate vuex store state outside mutation handlers. assert vuex.esm-bundler.js:83 enableStrictMode vuex.esm-bundler.js:347 // ... select multiselect.vue:294 onClick multiselect.vue:47 node_modules chunk-KQJ3BTR7.js:8799 // ... node_modules chunk-KQJ3BTR7.js:1423 // ... findLabel editLabels.vue:92 // ... searchTimeout multiselect.vue:268 setTimeout handler*search multiselect.vue:267 // ... 1 multiselect.vue:28 ``` or: ``` Error: [vuex] do not mutate vuex store state outside mutation handlers. assert vuex.esm-bundler.js:83 enableStrictMode vuex.esm-bundler.js:347 // ... 2 TaskDetailView.vue:44 // ... updateData prioritySelect.vue:47 ```

dpschen commented

2022-07-16 19:57:12 +00:00

Can you reproduce this on https://try.vikunja.io ?
Which version are you running on?

Can you reproduce this on https://try.vikunja.io ? Which version are you running on?

andreymal commented

2022-07-16 20:11:43 +00:00

@dpschen i use the git main branch with yarn serve

But your question made me check yarn build and I noticed that the compiled frontend does not have this error, hence try.vikunja.io does not have this error either.

Does it mean this is a bug somewhere inside the yarn serve implementation?

@dpschen i use the git main branch with `yarn serve` But your question made me check `yarn build` and I noticed that the compiled frontend does not have this error, hence `try.vikunja.io` does not have this error either. Does it mean this is a bug somewhere inside the `yarn serve` implementation?

dpschen commented

2022-07-16 20:23:44 +00:00

When using build the error will not be logged. Sometimes there are errors that are minor, so we don't want to annoy the user. In development (aka yarn serve) we want to see every problem.

The vuex issues you are seeing are not minor though. That should never happen.
@konrad Do we have a central place where we track these?

When using build the error will not be logged. Sometimes there are errors that are minor, so we don't want to annoy the user. In development (aka `yarn serve`) we want to see every problem. The vuex issues you are seeing are not minor though. That should never happen. @konrad Do we have a central place where we track these?

dpschen added the

kind/bug

label 2022-07-16 20:23:59 +00:00

konrad commented

2022-07-18 10:22:28 +00:00

Do we have a central place where we track these?

I don't think we have a place for those yet. Maybe we should just open an issue? Or better yet, fix when they come up?

> Do we have a central place where we track these? I don't think we have a place for those yet. Maybe we should just open an issue? Or better yet, fix when they come up?

konrad commented

2023-03-09 11:58:41 +00:00

Closing since we migrated to pina since this was opened.

konrad closed this issue

2023-03-09 11:58:41 +00:00

dpschen commented

2023-03-10 14:31:33 +00:00

I'm not sure but we might still be doing this.
To be absolutely sure that we do not change outsite of actions (since mutations and actions are unified in pinia) we would need to export only refs wrapped in readonly(). Most stores do that, but not all of them.

I'm not sure but we might still be doing this. To be absolutely sure that we do not change outsite of actions (since mutations and actions are unified in pinia) we would need to export only refs wrapped in `readonly()`. Most stores do that, but not all of them.

konrad referenced this issue from a commit

2024-02-07 14:00:34 +00:00

chore(deps): update dependency vue-tsc to v0.34.13 (#1945)

Sign in to join this conversation.