[BUG] - Task: Repeating interval could be set to negative value (which will delete repeating interval) #1955

New Issue

PewQuadrat · 2022-07-20T20:43:47Z

PewQuadrat commented

2022-07-20 20:43:47 +00:00

Hello,

it is possible to set the each input to a negative value, which will result in loss of the repeating interval.

BTW: How could otherwise an already defined repeating interval be resettet / deleted?

Tested and reproduced on Try

Greetings

Hello, it is possible to set the *each* input to a negative value, which will result in loss of the repeating interval. BTW: How could otherwise an already defined repeating interval be resettet / deleted? Tested and reproduced on Try Greetings

konrad added the

kind/bug

label 2022-07-20 21:53:05 +00:00

konrad commented

2022-07-21 10:02:53 +00:00

Resetting should work by setting the value to 0.

PewQuadrat commented

2022-07-21 10:40:01 +00:00

That's correct, but I think that is not intuitive for everybody.

Is it possible to show the same X as for the other date optoins?

Greetings

That's correct, but I think that is not intuitive for everybody. Is it possible to show the same X as for the other date optoins? ![image](/attachments/6044eec3-d992-4985-b292-c577ffdb9163) Greetings

image.png

3.0 KiB

konrad commented

2022-07-21 11:00:58 +00:00

That would probably work, yes.

👍 1

konrad referenced this issue from a commit

2022-07-21 13:00:34 +00:00

fix: add validation for negative repeat after values

konrad referenced this issue from a commit

2022-07-21 13:06:21 +00:00

fix: don't allow negative repeat amounts

konrad referenced this issue from a commit

2022-07-21 13:10:52 +00:00

feat: allow for easy reset of a repeating amount

konrad closed this issue

2022-07-21 13:10:52 +00:00

konrad commented

2022-07-21 13:11:33 +00:00

Negative values are now validated in dd461746a6 and 71c8540c74

I've also added an "X" to remove a repeating interval in 9cebf5305a

Negative values are now validated in https://kolaente.dev/vikunja/api/commit/dd461746a655d716ef142d96a2bcef5615de3dd9 and https://kolaente.dev/vikunja/frontend/commit/71c8540c74f8448a2fddb0791e28b22c76a6d4b6 I've also added an "X" to remove a repeating interval in https://kolaente.dev/vikunja/frontend/commit/9cebf5305a4658fe2d7b4d19e2c96c5b8541b29f

konrad referenced this issue from a commit

2024-02-07 14:00:34 +00:00

chore(deps): update typescript-eslint monorepo to v5.24.0 (#1955)

Sign in to join this conversation.