Copy URL of an attachment give Error #1973
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#1973
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Version information:
Frontend Version: 0.19.1
API Version: v0.19.2
Browser and OS Version: Firefox 104.0 / Windows 10
Steps to reproduce:
Expected behavior:
Copy the picture URL into the clipboard
Actual behavior:
Vikunja just shows an Error
Checklist:
I was not able to test on try.vikunja.io as the uploads do not work there.
I was not able to reproduce this on try. Upload worked fine, as did copying the url.
Are there any other errors in the browser console when you try to copy the url?
+1
I'm able to upload and copy the URL on try.vikunja.io now as well but the problem still exists on my instance.
I see no error in the console though.
@Bouni Are you running unstable?
All the other functions (download, delete, preview) work as expected.
My workaround for now is to preview and right click -> copy image url.
No, I run via docker-compose:
image: vikunja/frontend
Is it maybe related to the copy to clipboard functionality!?
Is there another place where vikunja utilized this function so that I can verify my guess?
Copying a share link uses the same code.
The exact same problem happens!
The only difference I can spot between my instance and try is that my instance runs locally without https where try obviously uses https ...
If it works on try but not in the release that means it's already been fixed in the development branch. I'll check if that's what has happened here.
I'm not sure if unstable = dev branch but I tested with
image: vikunja/frontend:unstable
and the problem is the same.Unstable is the dev branch. Everything is explained here: https://vikunja.io/docs/versions/
BTW. I am also running locally without HTTPS.
@stepanov1975 What browser and os are you using?
Windows 10 + Chrome Version 104.0.5112.102
As it turns out, the js clipboard api we're using to put the url into the clipboard is only available in "secure contexts". This means you'll need to access Vikunja via https or copying won't work.
It looks like this is nothing Vikunja can fix, therefore I'll close this issue.
I created a fallback that uses the deprecated
document.execCommand('copy')
: vikunja/frontend#2343Since it's currently widely supported I guess that's a fine compromise.
THanks!