vikunja
/
vikunja
6
43
Fork 69
Code Issues 152 Pull Requests 10 Packages Releases 32 Activity

Quick add magic time only works with certain date formats #1977

New Issue
Closed
opened 2022-09-12 04:35:19 +00:00 by WhileTrueDoLater · 5 comments
WhileTrueDoLater commented 2022-09-12 04:35:19 +00:00
Copy Link

Version information:

Frontend Version: 0.19.1
API Version: 0.19.2
Browser and OS Version: Librewolf 101.0-2 (64 bit), Windows 10 (Hosted on Docker, Ubuntu 22.04.1 LTS)

Steps to reproduce:

  1. Add task with format "task feb 17 at 10:00" or with any other of the non-working date formats with a specified time
  2. Task will be added but the time will be ignored and left in the task title
    ...

Expected behavior:

Quick add with time should work for any date format as described in the quick add magic hint popup.

Actual behavior:

Specifying a time does not work for every date format. Unchecked formats do not work as of writing this bug report. When saving with one of the non-working formats, the date is removed from the title, but the time is left and not used in the due date. Attempting to save one of these quick added tasks produces "Error: Invalid Time Value" until the due date is changed manually and the page is reloaded.

  • Today
  • Tomorrow
  • Next monday
  • This weekend
  • Later this week
  • Later next week
  • Next week
  • Next month
  • End of month
  • In 5 days [hours/weeks/months]
  • Tuesday (any weekday, will use the next date with that date)
  • 17/02/2021
  • Feb 17 (will use the current year)
  • 17th (will use the 17th of the current month)

Checklist:

  • I have provided all required information
  • I am using the latest release or the latest unstable build
  • I was able to reproduce the bug on try
<!-- Please fill out this issue template to report a bug. If you want to propose a new feature, please open a discussion thread in the forum: https://community.vikunja.io --> **Version information:** Frontend Version: 0.19.1 API Version: 0.19.2 Browser and OS Version: Librewolf 101.0-2 (64 bit), Windows 10 (Hosted on Docker, Ubuntu 22.04.1 LTS) **Steps to reproduce:** <!-- Add clear steps to reproduce the bug. Provide screenshots where applicable. --> 1. Add task with format "task feb 17 at 10:00" or with any other of the non-working date formats with a specified time 2. Task will be added but the time will be ignored and left in the task title ... **Expected behavior:** <!-- Describe what happened. --> Quick add with time should work for any date format as described in the quick add magic hint popup. **Actual behavior:** <!-- Describe what happened instead. --> Specifying a time does not work for every date format. Unchecked formats do not work as of writing this bug report. When saving with one of the non-working formats, the date is removed from the title, but the time is left and not used in the due date. Attempting to save one of these quick added tasks produces "Error: Invalid Time Value" until the due date is changed manually and the page is reloaded. * [x] Today * [x] Tomorrow * [x] Next monday * [x] This weekend * [x] Later this week * [x] Later next week * [x] Next week * [x] Next month * [x] End of month * [ ] In 5 days [hours/weeks/months] * [x] Tuesday (any weekday, will use the next date with that date) * [ ] 17/02/2021 * [ ] Feb 17 (will use the current year) * [ ] 17th (will use the 17th of the current month) **Checklist:** * [x] I have provided all required information * [x] I am using the latest release or the latest unstable build * [x] I was able to reproduce the bug on [try](https://try.vikunja.io)
konrad added the
kind/bug
 label 2022-09-13 15:14:01 +00:00
konrad commented 2022-09-13 15:17:40 +00:00
Owner
Copy Link

The only one which didn't work for me was the 17/02/2021. The others seem work.

Can you provide the exact test cases you tried?

The only one which didn't work for me was the `17/02/2021`. The others seem work. Can you provide the exact test cases you tried?
WhileTrueDoLater commented 2022-09-15 01:00:09 +00:00
Author
Copy Link

The remaining 3 cases convert as follows for me using the try installation. The results of the quick add magic are shown in the photo.

In order they are:

  • Something in 5 days at 10:00
  • Something 17th at 10:00
  • Something sep 17th at 10:00

image

Reversing the order also does not work:

  • Something at 10:00 in 5 days
  • something at 10:00 17th
  • something at 10:00 sep 17

image

The remaining 3 cases convert as follows for me using the [try installation](https://try.vikunja.io). The results of the quick add magic are shown in the photo. In order they are: * Something in 5 days at 10:00 * Something 17th at 10:00 * Something sep 17th at 10:00 ![image](/attachments/55b9728f-d2aa-4e9e-baef-6447612ce817) Reversing the order also does not work: * Something at 10:00 in 5 days * something at 10:00 17th * something at 10:00 sep 17 ![image](/attachments/68837b82-1a65-48f5-bd23-f8358445cd9d)
image.png
8.7 KiB
image.png
8.1 KiB
👍 1
konrad commented 2022-09-15 09:52:56 +00:00
Owner
Copy Link

PR is up: vikunja/frontend#2367

You can use the preview link (should be coming shortly) in the PR to test the changes.

PR is up: https://kolaente.dev/vikunja/frontend/pulls/2367 You can use the preview link (should be coming shortly) in the PR to test the changes.
konrad commented 2022-09-15 11:59:51 +00:00
Owner
Copy Link

The PR is merged, please chck with the next unstable build (~30 min).

The PR is merged, please chck with the next unstable build (~30 min).
WhileTrueDoLater commented 2022-09-15 15:22:38 +00:00
Author
Copy Link

Confirmed working on the latest test installation

Also confirmed using the unstable docker image on my own installaion

Confirmed working on the latest test installation Also confirmed using the unstable docker image on my own installaion
🎉 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
renovate/lowlight-3.x
renovate/golang.org-x-sync-0.x
renovate/major-dev-dependencies
renovate/github.com-asaskevich-govalidator-11.x
renovate/github.com-wneessen-go-mail-0.x
renovate/golangci-golangci-lint-1.x
feature/better-filter-syntax
fix/tiptap-task-list
renovate/flexsearch-0.x
feature/zod-schema
renovate/github.com-typesense-typesense-go-1.x
renovate/github.com-golang-jwt-jwt-v4-5.x
automatic-year-range-for-go-header-template
feature/hide-forbidden-related-tasks
renovate/golang-1.x
release/0.20
release/0.17
release/0.16
release/0.15
release/0.14
release/0.13
v0.23.0
v0.22.1
v0.22.0
v0.21.0
v0.20.4
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.2
v0.19.1
v0.19.0
v0.18.1
v0.18.0
v0.17.1
v0.17.0
v0.16.1
v0.16.0
v0.15.1
v0.15.0
v0.14.1
v0.14.0
v0.13.1
v0.13
v0.12
v0.11
v0.10
v0.9
v0.8
v0.7
v0.6
v0.5
v0.4
v0.3
v0.2
v0.1
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1977
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?