Improve sharing with team #1979

New Issue

dpschen · 2022-09-14T08:48:15Z

dpschen commented

2022-09-14 08:48:15 +00:00

Version information:

Frontend Version: dev
API Version: dev
Browser and OS Version: all

Steps to reproduce:

Don't be in any team
Open the team share modal

Expected behavior:

The 'Shared with these teams' area is not shown

Actual behavior:

The 'Shared with these teams' is shown. See screenshot:

Checklist:

I have provided all required information
I am using the latest release or the latest unstable build
I was able to reproduce the bug on try

**Version information:** Frontend Version: dev API Version: dev Browser and OS Version: all **Steps to reproduce:**  1. Don't be in any team 2. Open the team share modal **Expected behavior:**  The 'Shared with these teams' area is not shown **Actual behavior:**  The 'Shared with these teams' is shown. See screenshot: ![image](/attachments/656070fe-1cc9-4a68-a8c6-773c2af924f7) **Checklist:** * [x] I have provided all required information * [x] I am using the latest release or the latest unstable build * [x] I was able to reproduce the bug on [try](https://try.vikunja.io)

image.png

46 KiB

dpschen added the

kind/bug

label 2022-09-14 08:48:15 +00:00

dpschen referenced this issue from vikunja/frontend

2022-09-14 08:48:33 +00:00

feat(link shares): allows switching the initial view by passing a query parameter #2335

konrad commented

2022-09-14 12:43:49 +00:00

So the "Shared with these teams" area should not be shown if the user is not in any team?

I wouldn't consider this a bug but a UX-improvement.

So the "Shared with these teams" area should not be shown if the user is not in any team? I wouldn't consider this a bug but a UX-improvement.

dpschen commented

2022-09-14 13:51:13 +00:00

I see it as a bug, since the user is shown some control elements that don't have functionality for him, aka are broken.

I thought that removing the controls completely would be the best choice if the user isn't part of any team because it seems to indicate that the installation is for a single-user only, thus no teams necessary. Showing the UI in this case might be confusing or distracting / congesting the ui.

In case I oversaw something and there could be other reasons why there is no team available we could disable the UI instead and inform that the user needs to be in a team in order to share it with one.

I see it as a bug, since the user is shown some control elements that don't have functionality for him, aka are broken. I thought that removing the controls completely would be the best choice if the user isn't part of any team because it seems to indicate that the installation is for a single-user only, thus no teams necessary. Showing the UI in this case might be confusing or distracting / congesting the ui. In case I oversaw something and there could be other reasons why there is no team available we could disable the UI instead and inform that the user needs to be in a team in order to share it with one.

konrad referenced this issue from vikunja/frontend

2022-09-14 14:25:49 +00:00

feat(link shares): allows switching the initial view by passing a query parameter #2335

Sign in to join this conversation.