Edit comment with an expired JWT doesn't throw an error #2006

New Issue

jbd7 · 2023-01-23T15:00:28Z

jbd7 commented

2023-01-23 15:00:28 +00:00

Description

Issue: Editing a comment with an expired JWT doesn't throw an error

Steps to reproduce:

Log in self hosted Vikunja instance
Open a task wit comments, e.g. https://vikunja.tld/tasks/125
Leave it open for a long time and do something else
Go back to that opened page
Click on the "Edit" link below a comment
Edit comment and click "Save"

What happens:

the web page shows the edited comment, but that comment is actually not saved in the DB
no error is snown

What is expected:

Clicking on save throw a "error 401, invalid or expired jwt" error, just like what happens when trying to add a new comment to a task with an expired jwt.
the edited comment is still visible to the user, so that they can copy it and paste it after logging in again into Vikunja

Notes:

I didn't try on the Vikunja demo website as I don't control the JWT expiry.

Vikunja Frontend Version

0.19.1

Vikunja API Version

v0.19.2

Browser and version

Chrome Version 108.0.5359.125 (Official Build) (64-bit)

Can you reproduce the bug on the Vikunja demo site?

No

Screenshots

No response

### Description Issue: Editing a comment with an expired JWT doesn't throw an error Steps to reproduce: - Log in self hosted Vikunja instance - Open a task wit comments, e.g. https://vikunja.tld/tasks/125 - Leave it open for a long time and do something else - Go back to that opened page - Click on the "Edit" link below a comment - Edit comment and click "Save" What happens: - the web page shows the edited comment, but that comment is actually not saved in the DB - no error is snown What is expected: - Clicking on save throw a "error 401, invalid or expired jwt" error, just like what happens when trying to add a new comment to a task with an expired jwt. - the edited comment is still visible to the user, so that they can copy it and paste it after logging in again into Vikunja Notes: - I didn't try on the Vikunja demo website as I don't control the JWT expiry. ### Vikunja Frontend Version 0.19.1 ### Vikunja API Version v0.19.2 ### Browser and version Chrome Version 108.0.5359.125 (Official Build) (64-bit) ### Can you reproduce the bug on the Vikunja demo site? No ### Screenshots _No response_

jbd7 added the

kind/bug

label 2023-01-23 15:00:28 +00:00

konrad referenced this issue from a commit

2023-01-25 14:06:20 +00:00

fix: make sure global error handler handles unrejected promises correctly

konrad closed this issue

2023-01-25 14:06:20 +00:00

konrad commented

2023-01-25 14:08:56 +00:00

Should be fixed with 4576da0dd3 - please check with the next unstable build or on try.

Should be fixed with https://kolaente.dev/vikunja/frontend/commit/4576da0dd394ee68801b1dc424c9550896d63737 - please check with the next unstable build or on try.

viehlieb referenced this issue from a commit

2023-02-01 16:07:50 +00:00

fix: make sure global error handler handles unrejected promises correctly

konrad referenced this issue from a commit

2024-02-07 14:00:34 +00:00

chore(deps): update dependency rollup to v2.75.5 (#2006)

Sign in to join this conversation.