vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: make sure the app is fully ready before trying to redirect to the login page #1337

Manually merged
dpschen merged 3 commits from fix/app-ready into main 2022-02-05 16:49:14 +00:00
Conversation 2 Commits 3 Files Changed 3 +2 -6
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 24a154422d - Show all commits

4
src/components/misc/ready.vue
View File

@ -60,7 +60,7 @@ const route = useRoute()
const store = useStore()
const ready = computed(() => store.state.vikunjaReady)
const ready = ref(false)
const online = useOnline()
const error = ref('')
@ -73,7 +73,7 @@ async function load() {
if (typeof redirectTo !== 'undefined') {
await router.push(redirectTo)
dpschen marked this conversation as resolved
konrad commented 2022-01-08 14:49:28 +00:00
Review
Copy Link

I wanted to make sure the app would only be ready after it was redirected. What bothers me here is I had to move the store.commit('vikunjaReady', true) out of the loadApp action. It should be fine since this is the only place where that action is used, but I'm not quite sure about it.

I wanted to make sure the app would only be ready after it was redirected. What bothers me here is I had to move the `store.commit('vikunjaReady', true)` out of the `loadApp` action. It should be fine since this is the only place where that action is used, but I'm not quite sure about it.
dpschen commented 2022-01-31 22:00:29 +00:00
Review
Copy Link

Can you give a bit more context what you mean by:

I wanted to make sure the app would only be ready after it was redirected.

Can you give a bit more context what you mean by: > I wanted to make sure the app would only be ready after it was redirected.
konrad commented 2022-02-01 20:27:00 +00:00
Review
Copy Link

That was meant the other way around - "...make sure the app would only redirect after it was ready"

See my lenghty comment below.

That was meant the other way around - "...make sure the app would only redirect after it was ready" See my lenghty comment below.
😆 1
dpschen commented 2022-02-01 21:27:46 +00:00
Review
Copy Link

Ahh that makes more sense. I really broke my mind on this one :D

Ahh that makes more sense. I really broke my mind on this one :D
}
store.commit('vikunjaReady', true)
ready.value = true
} catch (e: any) {
error.value = e
}

4
src/store/index.js
View File

@ -43,7 +43,6 @@ export const store = createStore({
menuActive: true,
keyboardShortcutsActive: false,
quickActionsActive: false,
vikunjaReady: false,
},
mutations: {
[LOADING](state, loading) {
@ -79,9 +78,6 @@ export const store = createStore({
[BACKGROUND](state, background) {
state.background = background
},
vikunjaReady(state, ready) {
state.vikunjaReady = ready
},
},
actions: {
async [CURRENT_LIST]({state, commit}, currentList) {