vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: add date math for filters #1342

Merged
konrad merged 88 commits from feature/date-math into main 2022-03-28 17:30:43 +00:00
Conversation 2 Commits 88 Files Changed 18 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1648bcdb70 - Show all commits

4
src/components/date/datepickerWithRange.vue
View File

@ -2,9 +2,9 @@
<div class="datepicker-with-range-container">
<popup>
<template #trigger="{toggle}">
<a @click.prevent.stop="toggle()">
<x-button @click.prevent.stop="toggle()" type="secondary" :shadow="false" class="mb-2">
konrad marked this conversation as resolved Outdated
dpschen commented 2022-02-06 13:48:51 +00:00
Outdated
Review
Copy Link

Provide buttonText as slot prop aswell

Provide `buttonText` as slot prop aswell
konrad commented 2022-02-06 17:51:12 +00:00
Outdated
Review
Copy Link

Done.

Done.
{{ $t('task.show.select') }}
konrad marked this conversation as resolved Outdated
dpschen commented 2022-02-06 13:10:28 +00:00
Outdated
Review
Copy Link

The styles (=props) selected for the button are hightly specific and create an indirect dependency to its indented use case. The latter might change in the future and then we have to remember this dependency. This is why I think it makes sense to remove at least the specific use case of this button. Since we wouldn't use it then at all anymore (since you need to overwrite the default slot) it might make it simpler to only define the slot.

The styles (=props) selected for the button are hightly specific and create an indirect dependency to its indented use case. The latter might change in the future and then we have to remember this dependency. This is why I think it makes sense to remove at least the specific use case of this button. Since we wouldn't use it then at all anymore (since you need to overwrite the default slot) it might make it simpler to only define the slot.
konrad commented 2022-02-06 17:47:10 +00:00
Outdated
Review
Copy Link

Moved everything to a slot.

Moved everything to a slot.
👍 1
</a>
</x-button>
</template>
<template #content="{isOpen}">
<div class="datepicker-with-range" :class="{'is-open': isOpen}">