vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: add date math for filters #1342

Merged
konrad merged 88 commits from feature/date-math into main 2022-03-28 17:30:43 +00:00
Conversation 2 Commits 88 Files Changed 18 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 294e89b6f7 - Show all commits

2
src/components/date/datepickerWithRange.vue
View File

@ -210,9 +210,9 @@ const customRangeActive = computed<Boolean>(() => {
<style lang="scss" scoped>
.datepicker-with-range-container {
position: relative;
z-index: 10;
:deep(.popup) {
z-index: 10;
margin-top: 1rem;
dpschen commented 2022-02-06 13:25:25 +00:00
Outdated
Review
Copy Link

I think this is a good usecase for a reactive.

I think this is a good usecase for a reactive.
konrad commented 2022-02-06 18:43:09 +00:00
Outdated
Review
Copy Link

What would be the advantage over a ref?

What would be the advantage over a ref?
dpschen commented 2022-02-06 19:21:31 +00:00
Outdated
Review
Copy Link

Both values can be changed at the same time
=> watchers aren't triggered twice when you change stuff shortly after each other.

Both values can be changed at the same time => watchers aren't triggered twice when you change stuff shortly after each other.
👍 1
konrad commented 2022-02-06 19:25:27 +00:00
Outdated
Review
Copy Link

How do I type it properly? If I only pass a string into a reactive it complains I should pass in an object instead.

Edit: using String (capital S) seems to work.

How do I type it properly? If I only pass a string into a reactive it complains I should pass in an object instead. Edit: using `String` (capital S) seems to work.
konrad commented 2022-02-06 19:27:25 +00:00
Outdated
Review
Copy Link

Okay even with the typing solved it still complains when trying to set it: Because we do const from = ... I won't be able to do from = fromDate. Any idea how to solve this?

Okay even with the typing solved it still complains when trying to set it: Because we do `const from = ...` I won't be able to do `from = fromDate`. Any idea how to solve this?
border-radius: $radius;
border: 1px solid var(--grey-200);