vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: add date math for filters #1342

Merged
konrad merged 88 commits from feature/date-math into main 2022-03-28 17:30:43 +00:00
Conversation 2 Commits 88 Files Changed 18 +1 -2
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6d6f2b4e33 - Show all commits

3
src/views/tasks/ShowTasks.vue
View File

@ -212,8 +212,7 @@ function updateTasks(updatedTask) {
}
konrad marked this conversation as resolved Outdated
dpschen commented 2022-02-06 13:41:41 +00:00
Outdated
Review
Copy Link

Instead of creating the params already in snake_case:
Wait until the last moment (ideally abstracted away from a apiClient) until you convert params from camelCase to snake_case, needed by the api. This way we use consequently use camelCase in most areas of the frontend – which is what you usually do in JS.

Instead of creating the params already in snake_case: Wait until the last moment (ideally abstracted away from a apiClient) until you convert params from camelCase to snake_case, needed by the api. This way we use consequently use camelCase in most areas of the frontend – which is what you usually do in JS.
konrad commented 2022-02-06 19:49:16 +00:00
Outdated
Review
Copy Link

I agree. However, this whole filter thing is a mess right now, not only here. I'd like to fix this everywhere at once at some point, simplifying the filter handling in the process as well.

That being said, I've changed there here for now.

I agree. However, this whole filter thing is a mess right now, not only here. I'd like to fix this everywhere at once at some point, simplifying the filter handling in the process as well. That being said, I've changed there here for now.
watchEffect(() => loadPendingTasks(dateFrom.value as string, dateTo.value as string))
// loadPendingTasks()
watchEffect(() => setTitle(pageTitle))
watchEffect(() => setTitle(pageTitle.value))
</script>
<style lang="scss" scoped>