vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: add date math for filters #1342

Merged
konrad merged 88 commits from feature/date-math into main 2022-03-28 17:30:43 +00:00
Conversation 2 Commits 88 Files Changed 18 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a6480cdb75 - Show all commits

4
src/components/date/datemathHelp.vue
View File

@ -15,12 +15,12 @@
<i18n-t keypath="input.datepickerRange.math.similar">
<BaseButton
konrad marked this conversation as resolved Outdated
dpschen commented 2022-02-06 21:45:23 +00:00
Outdated
Review
Copy Link

use BaseButton

use BaseButton
konrad commented 2022-02-06 22:06:01 +00:00
Outdated
Review
Copy Link

Done.

Done.
href="https://grafana.com/docs/grafana/latest/dashboards/time-range-controls/"
rel="noreferrer noopener nofollow" target="_blank">
target="_blank">
konrad marked this conversation as resolved Outdated
dpschen commented 2022-02-07 10:50:27 +00:00
Outdated
Review
Copy Link

Remove rel attribute here and below.
Show we also add target="_blank" as default for the BaseButton is a link case?

Remove rel attribute here and below. Show we also add `target="_blank"` as default for the BaseButton is a link case?
konrad commented 2022-02-20 20:07:34 +00:00
Outdated
Review
Copy Link

Show we also add target="_blank" as default for the BaseButton is a link case?

Mh I think there will still be cases where we want to control this so right now I think we should not add one.

> Show we also add target="_blank" as default for the BaseButton is a link case? Mh I think there will still be cases where we want to control this so right now I think we should not add one.
👍 1
Grafana
</BaseButton>
<BaseButton
konrad marked this conversation as resolved Outdated
dpschen commented 2022-02-06 21:45:29 +00:00
Outdated
Review
Copy Link

use BaseButton

use BaseButton
href="https://www.elastic.co/guide/en/elasticsearch/reference/7.3/common-options.html#date-math"
rel="noreferrer noopener nofollow" target="_blank">
target="_blank">
Elasticsearch
</BaseButton>
</i18n-t>