vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: add date math for filters #1342

Merged
konrad merged 88 commits from feature/date-math into main 2022-03-28 17:30:43 +00:00
Conversation 2 Commits 88 Files Changed 18 +13 -13
2 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a78ca6fad3 - Show all commits

22
src/components/date/datepickerWithRange.vue
View File

@ -174,19 +174,19 @@ const buttonText = computed<string>(() => {
<style lang="scss" scoped>
.datepicker-with-range-container {
position: relative;
konrad marked this conversation as resolved Outdated
dpschen commented 2022-02-06 13:20:27 +00:00
Outdated
Review
Copy Link

Picky:

I like to group imports from external packages and from internal stuff.
Usally I follow this order (but not strict):

  • external packages beginning with vue libs

  • external packages other libs and css

  • internal instances like store, message, etc

  • services and models

  • component imports

  • helpers

As you can see this is more or less random, so happy to discuss this.
Or we can simple keep it random :D

Picky: I like to group imports from external packages and from internal stuff. Usally I follow this order (but not strict): - external packages beginning with vue libs - external packages other libs and css - internal instances like store, message, etc - services and models - component imports - helpers As you can see this is more or less random, so happy to discuss this. Or we can simple keep it random :D
konrad commented 2022-02-06 18:31:29 +00:00
Outdated
Review
Copy Link

Oh I think it absolutely makes sense to have something like that, even if not strictly enforced. Do you think we could put this in a linter?

Oh I think it absolutely makes sense to have something like that, even if not strictly enforced. Do you think we could put this in a linter?
dpschen commented 2022-02-06 19:20:09 +00:00
Outdated
Review
Copy Link

I think I encountered at least something like external stuff first in a linter already.

I think I encountered at least something like external stuff first in a linter already.
👍 1
}
:deep(.popup) {
z-index: 10;
margin-top: 1rem;
border-radius: $radius;
border: 1px solid var(--grey-200);
background-color: var(--white);
box-shadow: $shadow;
:deep(.popup) {
z-index: 10;
konrad marked this conversation as resolved Outdated
dpschen commented 2022-02-06 13:21:28 +00:00
Outdated
Review
Copy Link

After using it a while I prefer now to use the useStore method to get the current store instance.
The reason is that it makes it easier to refactor in composables later because useStore will always give you the store.

After using it a while I prefer now to use the `useStore` method to get the current store instance. The reason is that it makes it easier to refactor in composables later because `useStore` will always give you the store.
konrad commented 2022-02-06 18:31:57 +00:00
Outdated
Review
Copy Link

Makes sense! Changed it.

Makes sense! Changed it.
margin-top: 1rem;
border-radius: $radius;
border: 1px solid var(--grey-200);
background-color: var(--white);
box-shadow: $shadow;
&.is-open {
width: 500px;
height: 320px;
}
&.is-open {
width: 500px;
height: 320px;
}
}
konrad marked this conversation as resolved Outdated
dpschen commented 2022-02-06 13:50:28 +00:00
Outdated
Review
Copy Link

We could remove this prop if we would only expose the slot for the trigger.

We could remove this prop if we would only expose the slot for the trigger.
konrad commented 2022-02-06 17:51:26 +00:00
Outdated
Review
Copy Link

Done.

Done.

4
src/components/list/partials/filters.vue
View File

@ -588,7 +588,7 @@ export default {
}
</script>
<style lang="scss">
<style lang="scss" scoped>
.single-value-control {
display: flex;
align-items: center;
@ -598,7 +598,7 @@ export default {
}
}
.datepicker-with-range-container .popup {
:deep(.datepicker-with-range-container .popup) {
right: 0;
}
</style>