vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: increase task drop area size for bucket list #1512

Merged
konrad merged 3 commits from dpschen/frontend:feature/increase-drop-area-size into main 2022-02-13 13:12:59 +00:00
Conversation 4 Commits 3 Files Changed 3 +147 -104
dpschen commented 2022-02-08 20:47:42 +00:00
Member
Copy Link

Fixes: https://github.com/go-vikunja/frontend/issues/38

Fixes: https://github.com/go-vikunja/frontend/issues/38
frederick commented 2022-02-08 20:51:31 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1512-featureincrease-drop-area-size--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1512-featureincrease-drop-area-size--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2022-02-08 21:25:58 +00:00
Owner
Copy Link

(not sure if this is due to the PR still being WIP)

When dropping a task, this error happens:

image

And it looks like the task card shadows are somewhat off:

image

For reference, here's how it currently looks:

image

(not sure if this is due to the PR still being WIP) When dropping a task, this error happens: ![image](/attachments/7c6ad421-b2b0-4565-8e61-f47621dbcd36) And it looks like the task card shadows are somewhat off: ![image](/attachments/f0e54311-c03e-4d69-b612-efea8033b442) For reference, here's how it currently looks: ![image](/attachments/f6411da6-2abb-4e3d-ac7c-288133cf6ecd)
image.png
3.1 KiB
image.png
9.1 KiB
image.png
10 KiB
👍 1
dpschen commented 2022-02-08 22:15:13 +00:00
Author
Member
Copy Link

The sortable.next version seems to have a lot of errors.
E.g. this is a bug that is appering now, but is caused by the library:
https://github.com/SortableJS/vue.draggable.next/issues/108

The sortable.next version seems to have a lot of errors. E.g. this is a bug that is appering now, but is caused by the library: https://github.com/SortableJS/vue.draggable.next/issues/108
dpschen commented 2022-02-09 00:06:52 +00:00
Author
Member
Copy Link

Should all be fixed.

Getting a workaround for the vue.draggable error was especially nasty, see 8f62e89bbb.

Should all be fixed. Getting a workaround for the vue.draggable error was especially nasty, see https://kolaente.dev/vikunja/frontend/commit/8f62e89bbb640aaa63779ad824803905edafdcdc.
dpschen requested review from konrad 2022-02-09 00:07:03 +00:00
konrad was assigned by dpschen 2022-02-09 00:07:07 +00:00
dpschen changed title from WIP: feat: increase task drop area size for bucket list to feat: increase task drop area size for bucket list 2022-02-09 00:07:11 +00:00
konrad approved these changes 2022-02-13 12:42:27 +00:00
konrad left a comment
Owner

Seems to work great. Thanks!

Seems to work great. Thanks!
konrad merged commit cb395f3f69 into main 2022-02-13 13:12:59 +00:00
konrad deleted branch feature/increase-drop-area-size 2022-02-13 13:12:59 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1512
No description provided.
Delete Branch "dpschen/frontend:feature/increase-drop-area-size"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?