fix: remove obsolete watchEffect #1795

Merged

konrad merged 1 commits from dpschen/frontend:feature/fix-remove-obsolete-watchEffect into main 2022-04-18 17:32:22 +00:00

Conversation 3 Commits 1 Files Changed 1 +3 -10

dpschen commented 2022-04-09 23:51:56 +00:00

Member

Copy Link

fixing #1616 (comment)

fixing https://kolaente.dev/vikunja/frontend/pulls/1616#issuecomment-28994

konrad was assigned by dpschen 2022-04-09 23:52:03 +00:00

dpschen referenced this pull request 2022-04-09 23:52:23 +00:00

fix: setting list background in store #1616

dpschen force-pushed feature/fix-remove-obsolete-watchEffect from af9efea4b7 to 45cc40c283 2022-04-10 00:00:49 +00:00 Compare

frederick commented 2022-04-10 00:05:39 +00:00

Member

Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1795-feature-fix-remove-obsolete-watc--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1795-feature-fix-remove-obsolete-watc--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad commented 2022-04-10 18:39:09 +00:00

Owner

Copy Link

CI seems to fail, maybe it was not as obsolete as we thought - at least a few of the failing testcases seem to be unrelated to the change so I restarted the build to see if they really are unrelated.

CI seems to fail, maybe it was not as obsolete as we thought - at least a few of the failing testcases seem to be unrelated to the change so I restarted the build to see if they really are unrelated.

👍 1

dpschen force-pushed feature/fix-remove-obsolete-watchEffect from 45cc40c283 to 805a4740df 2022-04-11 17:18:45 +00:00 Compare

dpschen commented 2022-04-11 17:23:47 +00:00

Author

Member

Copy Link

Fixed. Needed a getter to access the property.

Fixed. [Needed a getter](https://vuejs.org/guide/essentials/watchers.html#basic-example=) to access the property.

konrad approved these changes 2022-04-18 17:32:11 +00:00

konrad left a comment

Owner

Seems to work fine now. List contents are loaded multiple times though but it looks like that's already broken on main.

Seems to work fine now. List contents are loaded multiple times though but it looks like that's already broken on main.

👍 1

konrad merged commit 9c2438026b into main 2022-04-18 17:32:22 +00:00

konrad referenced this issue from a commit 2022-04-18 17:32:22 +00:00

fix: remove obsolete watchEffect (#1795)

konrad deleted branch feature/fix-remove-obsolete-watchEffect 2022-04-18 17:32:23 +00:00

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

konrad

Labels

Clear labels   

area/internal-code

  

changes requested

  

confirmed

  

dependencies

  

duplicate

This issue or pull request already exists

  

good first issue

  

help wanted

Need some help

  

hosting

  

invalid

Something is wrong

  

kind/bug

Something is not working

  

kind/feature

New feature

  

question

More information is needed

  

wontfix

This won't be fixed

No Label

area/internal-code

changes requested

confirmed

dependencies

duplicate

good first issue

help wanted

hosting

invalid

kind/bug

kind/feature

question

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

konrad

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1795

No description provided.