feat: improve password component #1802

dpschen · 2022-04-10T11:12:04Z

dpschen commented

2022-04-10 11:12:04 +00:00

No description provided.

konrad was assigned by dpschen

2022-04-10 11:12:04 +00:00

dpschen added 1 commit 2022-04-10 11:12:05 +00:00

continuous-integration/drone/pr Build is passing Details

6f6ef6932e

feat: improve password component

dpschen reviewed 2022-04-10 11:13:40 +00:00

src/components/input/password.vue

						
				@ -42,3 +43,1 @@

				const passwordFieldType = ref<String>('password')

				const password = ref<String>('')

				const isValid = ref<Boolean>(!props.validateInitially)

				const passwordFieldType = ref('password')

dpschen commented

2022-04-10 11:13:40 +00:00

Default ref field type is always undefined + type of initial value. So no need to explicity set.
Additionally if set the types should be the lower case version string and boolean

Default ref field type is always `undefined` + type of initial value. So no need to explicity set. Additionally if set the types should be the lower case version `string` and `boolean`

👍 1

dpschen reviewed 2022-04-10 11:15:30 +00:00

src/components/input/password.vue

						
				@ -53,4 +51,2 @@

				)

				function validate() {

					useDebounceFn(() => {

dpschen commented

2022-04-10 11:15:30 +00:00

By using the useDebounceFn this way the returned function wouldn't be reused. Which is what you want, see: https://vueuse.org/shared/usedebouncefn/

👍 1

frederick commented

2022-04-10 11:16:25 +00:00

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1802-feature-feat-improve-password-co--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1802-feature-feat-improve-password-co--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad approved these changes 2022-04-10 19:00:06 +00:00

konrad left a comment

Thanks!

🎉 1

konrad merged commit ed8eb84617 into main

2022-04-10 19:00:12 +00:00

konrad deleted branch feature/feat-improve-password-component

2022-04-10 19:00:12 +00:00

konrad referenced this issue from a commit

2022-04-10 19:00:12 +00:00

feat: improve password component (#1802)

This repo is archived. You cannot comment on pull requests.