feature/feat-improve-ts-setup #1812
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Blocks
#1800 feat: improved checkbox
vikunja/frontend
Reference: vikunja/frontend#1812
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/feat-improve-ts-setup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This implements the vue ts setup by https://github.com/vuejs/create-vue
fe5e79a90a
toece7f39623
ece7f39623
to9cdb507ace
9cdb507ace
to41123d7bc1
I guess this is already much better.
@konrad: any idea how to disable ts from accessing the drone ts stuff:
a26441206b
to772668e91b
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://1812-feature-feat-improve-ts-setup--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
WIP: feature/feat-improve-ts-setupto feature/feat-improve-ts-setupOkay I was confused when I wrote this :D — fixed
@ -0,0 +10,4 @@
// "allowJs": true,
// "allowSyntheticDefaultImports": true,
// "sourceMap": true,
// "strictNullChecks": true,
I was not sure about these options.
The latter should probably be enabled.
Does the linter still pass when it is enabled?
This only affects tslint.
I googled a bit and I think I would use the following:
If we need to we can still use js if we disable the rule for that line.
It seems good to have
allowSyntheticDefaultImports
disabledChanged.
Anything else missing for the merge?
I think this should be fine.
@ -0,0 +6,4 @@
"composite": true,
"baseUrl": ".",
// "importHelpers": true,
Isn't this invalid json with the
//
?Yes:
7fdb13780d
tof735a58c51
@konrad Anything blocking this from beeing merged?
82d7e31f4a
tod61ecec53a
d61ecec53a
to44fa1e3697
44fa1e3697
toaca400ff52
Why did you rename
src/types/window.d.ts
tocrowdin.cli
?@ -0,0 +20,4 @@
export default (on, config) => {
// `on` is used to hook into various events Cypress emits
// `config` is the resolved Cypress config
on('dev-server:start', (options) => {
Oh so this will start a dev server when starting cypress?
I think we should document this in the cypress readme.
I think it waits for the server to start.
I thought I got this from the create-vue template as well. But seems like it's not from there. Searching via sourcegraph it seems I got it from some of the cypress documentation.
I think it would be good to know what this actually does and document it properly...
Okay I think I get it now:
It's for the new component testing. We aren't doing this yet, so there is nothing to configure yet. This just enables us to do this in the future. If we do, we should document it. As of now I don't see the need, since it's just the preparation not an actual usage.
I do not grasp yet when cypress component testing makes sense for us, since if I understand it correctly goes a bit into the domain of what vitest does.
Component testing in cypress 10 doesn't work via plugins anymore.
Plugins were removed, so I removed them as well.
See:
ac1004f96e
and
https://docs.cypress.io/guides/references/migration-guide#Plugins-File-Removed=
@ -0,0 +4,4 @@
"compilerOptions": {
"isolatedModules": false,
"target": "es5",
"lib": ["es5", "dom"],
Not
es6
?I took this from here: https://github.com/vuejs/create-vue-templates/blob/main/typescript-router-vitest-cypress/cypress/tsconfig.json
Not sure about the reason.
Does it work with
es6
?Tbh I don't even understand why the cypress folder needs its own tsconfig.
So I'm not really sure what implications the change to es6 would have.
Since there don't seem any problems in the test I guess keeping it as is seems fine.
Does that work for you?
Ah, didn't see this was the cypress tsconfig.
I think this is fine.
I didn't. They are both empty files. That's why git though I have moved them.
Not sure where the file is coming from though. I guess can be removed if there is'nt something useful that we want to add.
By the way: Cypress 10 is coming. Not sure what that means for us…
Since cypress 10 is now merged, could you rebase on
main
and check again?Other than my two last comments this should be good to merge.
aca400ff52
to000ba4a502
000ba4a502
tod78be8f859
ac1004f96e
tocedada85ea
Should be fine, please feel free to merge once rebased on
main
.Thank you for the effort.
cedada85ea
to345cb07605