feat: percentDoneSelect script setup #1922

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-percentDoneSelect-script-setup into main 2022-05-14 15:07:05 +00:00
Member

Things to improve in the future:

  • Don't set default value. Value should be defined outside, since this is an input element => keep it stupid => less errors.
  • reduce api surface. we don't need two kind of listeners. (update:modelValueand change)

I didn't change these because I only wanted to convert to script setup to keep this pull request simple and easy to merge.

Things to improve in the future: - Don't set default value. Value should be defined outside, since this is an input element => keep it stupid => less errors. - reduce api surface. we don't need two kind of listeners. (`update:modelValue`and `change`) I didn't change these because I only wanted to convert to script setup to keep this pull request simple and easy to merge.
dpschen force-pushed feature/feat-percentDoneSelect-script-setup from b9b0f28e36 to 95d7f45ea1 2022-05-10 21:55:57 +00:00 Compare
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1922-feature-feat-percentdoneselect-s--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1922-feature-feat-percentdoneselect-s--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
Owner

Good points in your comment.

Good points in your comment.
konrad merged commit 8d785cbf29 into main 2022-05-14 15:07:05 +00:00
konrad deleted branch feature/feat-percentDoneSelect-script-setup 2022-05-14 15:07:06 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.