feat: user DataExport script setup #1937

dpschen · 2022-05-10T22:18:48Z

dpschen commented

2022-05-10 22:18:48 +00:00

No description provided.

dpschen added 1 commit 2022-05-10 22:18:49 +00:00

continuous-integration/drone/pr Build is passing Details

6cebc120cf

feat: user DataExport script setup

frederick commented

2022-05-10 22:53:25 +00:00

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1937-feature-feat-user-data-export-sc--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1937-feature-feat-user-data-export-sc--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad reviewed 2022-05-14 14:43:48 +00:00

src/views/user/settings/DataExport.vue

						
				@ -43,4 +43,3 @@

				import DataExportService from '@/services/dataExport'

				export default defineComponent({

					name: 'user-settings-data-export',

konrad commented

2022-05-14 14:43:48 +00:00

Do we even need this?

dpschen commented

2022-05-19 19:09:05 +00:00

It's used here:

const dataExportService = shallowReactive(new DataExportService())

It's used here: ```ts const dataExportService = shallowReactive(new DataExportService()) ```

dpschen commented

2022-05-19 19:10:52 +00:00

Or wait. You meant the name, right?
I kept the definition because else we would need to rename the file to keep the same name in the devtools. Usually that should be in sync.

Or wait. You meant the name, right? I kept the definition because else we would need to rename the file to keep the same name in the devtools. Usually that should be in sync.

konrad commented

2022-05-20 05:31:20 +00:00

Yes, exactly the comment was about the name :)

Your response makes sense!

Yes, exactly the comment was about the name :) Your response makes sense!

konrad approved these changes 2022-05-14 14:44:55 +00:00

konrad left a comment

Fine to merge, apart from my comment.

dpschen commented

2022-05-19 20:43:41 +00:00

Fine to merge, apart from my comment.

I'll merge this. Let's clean up the names when we apply the linting. See

> Fine to merge, apart from my comment. I'll merge this. Let's clean up the names when we [apply the linting](https://kolaente.dev/vikunja/frontend/pulls/930). See - https://eslint.vuejs.org/rules/multi-word-component-names.html - https://eslint.vuejs.org/rules/component-definition-name-casing.html - https://eslint.vuejs.org/rules/component-name-in-template-casing.html

dpschen merged commit d11fae1c38 into main

2022-05-19 20:44:45 +00:00

dpschen deleted branch feature/feat-user-data-export-script-setup

2022-05-19 20:44:45 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers