vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: remove vue3 compat mode #1967

Merged
dpschen merged 2 commits from dpschen/frontend:feature/remove-vue3-compat-mode into main 2022-05-22 21:51:18 +00:00
Conversation 3 Commits 2 Files Changed 9 +13 -46
dpschen commented 2022-05-20 20:26:56 +00:00
Member
Copy Link
No description provided.
dpschen force-pushed feature/remove-vue3-compat-mode from bc1398b385 to b00bd69e70 2022-05-20 20:29:45 +00:00 Compare
konrad approved these changes 2022-05-22 14:48:01 +00:00
konrad left a comment
Owner

Looks good, anything we should be aware of with the package removed?

Looks good, anything we should be aware of with the package removed?
frederick commented 2022-05-22 15:04:09 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1967-feature-remove-vue3-compat-mode--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1967-feature-remove-vue3-compat-mode--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen commented 2022-05-22 15:05:46 +00:00
Author
Member
Copy Link

Looks good, anything we should be aware of with the package removed?

To be honest: I'm nost sure. I just thouht that all the package authors should have had enough time by now to fix issues with vue3 🤷‍♂️

> Looks good, anything we should be aware of with the package removed? To be honest: I'm nost sure. I just thouht that all the package authors should have had enough time by now to fix issues with vue3 🤷‍♂️
👍 1
dpschen force-pushed feature/remove-vue3-compat-mode from b00bd69e70 to 32aee02a86 2022-05-22 17:59:34 +00:00 Compare
dpschen commented 2022-05-22 18:06:50 +00:00
Author
Member
Copy Link

I needed to replace vuedraggable with a fork that contains a fix.
See: 32aee02a86

I needed to replace vuedraggable with a fork that contains a fix. See: https://kolaente.dev/vikunja/frontend/commit/32aee02a86a77fa3fd4bdb2489104fb0a4c53cda
dpschen force-pushed feature/remove-vue3-compat-mode from 32aee02a86 to 1569042471 2022-05-22 21:44:33 +00:00 Compare
dpschen merged commit 1569042471 into main 2022-05-22 21:51:18 +00:00
dpschen deleted branch feature/remove-vue3-compat-mode 2022-05-22 21:51:18 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1967
No description provided.
Delete Branch "dpschen/frontend:feature/remove-vue3-compat-mode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?