feat: edit-task script setup #1979

Merged
dpschen merged 1 commits from dpschen/frontend:feature/feat-edit-task-script-setup into main 2022-05-22 15:43:47 +00:00
Member
No description provided.
dpschen added 1 commit 2022-05-21 14:12:55 +00:00
continuous-integration/drone/pr Build is passing Details
65a056c0d7
feat: edit-task script setup
konrad reviewed 2022-05-22 14:45:53 +00:00
@ -155,0 +122,4 @@
// not update if new content from the outside was made available.
// See https://github.com/NikulinIlya/vue-easymde/issues/3
editorActive.value = false
nextTick(() => (editorActive.value = true))

I wonder if we can avoid this hack since we're no longer using the vue-esymde package?

I wonder if we can avoid this hack since we're no longer using the vue-esymde package?
Author
Member

Possibly, yes

Since we want to switch to tiptap I think we shouldn't waste our time with this.
I mostly wanted to port to script setup / ts here :)

Possibly, yes Since we want to switch to tiptap I think we shouldn't waste our time with this. I mostly wanted to port to script setup / ts here :)

Yeah, fully agree with that.

Yeah, fully agree with that.
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1979-feature-feat-edit-task-script-se--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1979-feature-feat-edit-task-script-se--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad approved these changes 2022-05-22 15:04:41 +00:00
Owner

Fine to merge once the CI passes.

Fine to merge once the CI passes.
dpschen merged commit cdf359da00 into main 2022-05-22 15:43:47 +00:00
dpschen deleted branch feature/feat-edit-task-script-setup 2022-05-22 15:43:47 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.