vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: replace our home-grown gantt implementation with ganttastic #2180

Merged
konrad merged 78 commits from feature/ganttastic into main 2022-10-27 16:03:27 +00:00
Conversation 41 Commits 78 Files Changed 48 +29 -31
1 changed files with 29 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit aefda38bdd - Show all commits

60
src/components/tasks/gantt-chart.vue
View File

@ -1,33 +1,32 @@
<template> <template>
<div> <Loading
konrad marked this conversation as resolved Outdated
dpschen commented 2022-07-21 22:21:18 +00:00
Outdated
Review
Copy Link

Use loading component. This way it's easier for us to refactor the is-loading styles from bulma later.

Use loading component. This way it's easier for us to refactor the `is-loading` styles from bulma later.
konrad commented 2022-08-02 12:02:07 +00:00
Outdated
Review
Copy Link

Done.

Done.
🎉 1
<Loading v-if="props.isLoading && tasks.size || dayjsLanguageLoading"
v-if="props.isLoading && tasks.size || dayjsLanguageLoading" class="gantt-container"
class="gantt-container" />
/> <div class="gantt-container" v-else>
<div class="gantt-container" v-else> <GGanttChart
<GGanttChart :date-format="DAYJS_ISO_DATE_FORMAT"
:date-format="DAYJS_ISO_DATE_FORMAT" :chart-start="isoToKebabDate(filters.dateFrom)"
:chart-start="isoToKebabDate(filters.dateFrom)" :chart-end="isoToKebabDate(filters.dateTo)"
:chart-end="isoToKebabDate(filters.dateTo)" precision="day"
precision="day" bar-start="startDate"
konrad marked this conversation as resolved Outdated
dpschen commented 2022-07-21 22:22:47 +00:00
Outdated
Review
Copy Link

Is it possible to use here simply inherit as value?

Is it possible to use here simply `inherit` as value?
konrad commented 2022-08-02 12:02:23 +00:00
Outdated
Review
Copy Link

Seems to work, yes.

Seems to work, yes.
🎉 1
dpschen commented 2022-10-07 11:46:32 +00:00
Outdated
Review
Copy Link

Not necessary with lates release. Removed.

Not necessary with lates release. Removed.
bar-start="startDate" bar-end="endDate"
bar-end="endDate" :grid="true"
:grid="true" @dragend-bar="updateGanttTask"
@dragend-bar="updateGanttTask" @dblclick-bar="openTask"
@dblclick-bar="openTask" :width="ganttChartWidth + 'px'"
:width="ganttChartWidth + 'px'" >
> <template #timeunit="{label, value}">
<template #timeunit="{label, value}"> <div
<div class="timeunit-wrapper"
class="timeunit-wrapper" :class="{'today': dayIsToday(label)}"
:class="{'today': dayIsToday(label)}" >
> <span>{{ value }}</span>
<span>{{ value }}</span> <span class="weekday">
<span class="weekday"> {{ weekdayFromTimeLabel(label) }}
{{ weekdayFromTimeLabel(label) }} </span>
</span> </div>
</div> </template>
</template>
<GGanttRow <GGanttRow
v-for="(bar, k) in ganttBars" v-for="(bar, k) in ganttBars"
:key="k" :key="k"
@ -35,7 +34,6 @@
:bars="bar" :bars="bar"
/> />
</GGanttChart> </GGanttChart>
</div>
</div> </div>
</template> </template>
@ -181,7 +179,7 @@ function dayIsToday(label: string): boolean {
<style lang="scss"> <style lang="scss">
// Not scoped because we need to style the elements inside the gantt chart component // Not scoped because we need to style the elements inside the gantt chart component
.g-gantt-chart { .g-gantt-chart {
width: 2000px; width: max-content;
} }
.g-gantt-row-label { .g-gantt-row-label {