vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: color the task color button when the task has a color set #2331

Merged
konrad merged 5 commits from feature/color-task-color-button into main 2022-09-15 12:46:13 +00:00
Conversation 12 Commits 5 Files Changed 6 -1
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4fce71f729 - Show all commits

1
src/components/misc/colorBubble.vue
View File

@ -17,7 +17,6 @@ defineProps< {
.color-bubble {
display: inline-block;
border-radius: 100%;
margin-right: 4px;
height: 10px;
width: 10px;
dpschen marked this conversation as resolved
dpschen commented 2022-09-15 12:32:38 +00:00
Review
Copy Link

If this margin should really be the same everywhere:

We should build this element so that the bubble has that distance included, meaning e.g. we would need to wrap two elements (the outer has an inner padding, the inner is the actual bubble).

If not:

The margin should be controlled from the outside.

If this margin should __really__ be the same everywhere: We should build this element so that the bubble has that distance included, meaning e.g. we would need to wrap two elements (the outer has an inner padding, the inner is the actual bubble). If not: The margin should be controlled from the outside.
konrad commented 2022-09-15 12:38:28 +00:00
Review
Copy Link

It's intended to not have any margin - the margin here is a leftover from copying the styles from the theme. I've added the margins everywhere where the ColorBubble component is included and the margins are needed.

It's intended to not have any margin - the margin here is a leftover from copying the styles from the theme. I've added the margins everywhere where the ColorBubble component is included and the margins are needed.
👍 1
flex-shrink: 0;