vikunja/frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat(link shares): allows switching the initial view by passing a query parameter #2335

Merged
konrad merged 11 commits from feature/redirect-to-specific-view into main 2022-09-14 16:37:56 +00:00
Conversation 10 Commits 11 Files Changed 4 +23 -29
1 changed files with 23 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6576b6148c - Show all commits

68
src/components/sharing/linkSharing.vue
View File

@ -79,7 +79,6 @@
>
<thead>
<tr>
<th>{{ $t('list.share.attributes.link') }}</th>
<th></th>
<th>{{ $t('list.share.links.view') }}</th>
konrad marked this conversation as resolved Outdated
dpschen commented 2022-09-08 09:10:22 +00:00
Outdated
Review
Copy Link

Why is the &nbsp; necessary?

Why is the `&nbsp;` necessary?
konrad commented 2022-09-08 11:59:13 +00:00
Outdated
Review
Copy Link

I thought it was necessary, looks like it isn't.

I thought it was necessary, looks like it isn't.
👍 1
<th>{{ $t('list.share.attributes.delete') }}</th>
@ -88,6 +87,37 @@
<tbody>
<tr :key="s.id" v-for="s in linkShares">
<td>
<p class="mb-2 is-italic" v-if="s.name !== ''">
{{ s.name }}
</p>
<p class="mb-2">
<i18n-t keypath="list.share.links.sharedBy">
<strong>{{ s.sharedBy.getDisplayName() }}</strong>
</i18n-t>
</p>
<p class="mb-2">
<template v-if="s.right === RIGHTS.ADMIN">
<span class="icon is-small">
<icon icon="lock"/>
</span>&nbsp;
{{ $t('list.share.right.admin') }}
</template>
<template v-else-if="s.right === RIGHTS.READ_WRITE">
<span class="icon is-small">
<icon icon="pen"/>
</span>&nbsp;
{{ $t('list.share.right.readWrite') }}
</template>
<template v-else>
<span class="icon is-small">
<icon icon="users"/>
</span>&nbsp;
{{ $t('list.share.right.read') }}
</template>
</p>
<div class="field has-addons no-input-mobile">
<div class="control">
<input
@ -110,38 +140,6 @@
</div>
</div>
</td>
<td class="type">
<p class="mb-2 is-italic" v-if="s.name !== ''">
{{ s.name }}
</p>
<p class="mb-2">
<i18n-t keypath="list.share.links.sharedBy">
<strong>{{ s.sharedBy.getDisplayName() }}</strong>
</i18n-t>
</p>
<p class="rights-item">
<template v-if="s.right === RIGHTS.ADMIN">
<span class="icon is-small">
<icon icon="lock"/>
</span>&nbsp;
{{ $t('list.share.right.admin') }}
</template>
<template v-else-if="s.right === RIGHTS.READ_WRITE">
<span class="icon is-small">
<icon icon="pen"/>
</span>&nbsp;
{{ $t('list.share.right.readWrite') }}
</template>
<template v-else>
<span class="icon is-small">
<icon icon="users"/>
</span>&nbsp;
{{ $t('list.share.right.read') }}
</template>
</p>
</td>
<td>
<div class="select">
<select v-model="selectedView[s.id]">
@ -299,9 +297,5 @@ function getShareLink(hash: string, view: ListView = LIST_VIEWS.LIST) {
overflow-y: auto
}
.rights-item {
white-space: nowrap;
}
@include modal-transition();
</style>