feat: port label store to pinia | pinia 1/9 #2391

Merged
konrad merged 2 commits from dpschen/frontend:feature/feat-pinia-label-store into main 2022-09-21 14:24:00 +00:00
Member
No description provided.
dpschen added the
kind/feature
label 2022-09-20 18:22:49 +00:00
dpschen force-pushed feature/feat-pinia-label-store from 6d6a2f661c to 216d931c53 2022-09-20 22:01:12 +00:00 Compare
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2391-feature-feat-pinia-label-store--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2391-feature-feat-pinia-label-store--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen requested review from konrad 2022-09-20 23:51:36 +00:00
konrad was assigned by dpschen 2022-09-20 23:51:39 +00:00
dpschen changed title from WIP: feat: port label store to pinia to feat: port label store to pinia 2022-09-20 23:51:41 +00:00
dpschen changed title from feat: port label store to pinia to feat: port label store to pinia | pinia 1/9 2022-09-21 09:28:23 +00:00
dpschen added 1 commit 2022-09-21 11:39:55 +00:00
continuous-integration/drone/pr Build is passing Details
3502a3f4c1
feat: port label store to pinia
konrad reviewed 2022-09-21 14:10:07 +00:00
@ -310,2 +312,3 @@
foundLabels() {
return this.$store.getters['labels/filterLabelsByQuery'](this.labels, this.query)
const labelStore = useLabelStore()

Shouldn't this use the setup function? (not script setup).

Shouldn't this use the setup function? (not `script setup`).
Author
Member

We could introduce a setup block in this component.
But since this pull request was only about having the fastest way to integrate the store I didn't see that necessary.

Setup would only require the additional import of computed. Plus we would need to export it again from that function.
So overall more complex then this quick fix here.

We could introduce a setup block in this component. But since this pull request was only about having the fastest way to integrate the store I didn't see that necessary. Setup would only require the additional import of `computed`. Plus we would need to export it again from that function. So overall more complex then this quick fix here.

Makes sense, especially considering this would be redundant once we'll have everything migrated over to script setup.

Makes sense, especially considering this would be redundant once we'll have everything migrated over to `script setup`.
Author
Member

Exactly :)

Exactly :)
dpschen marked this conversation as resolved
konrad approved these changes 2022-09-21 14:23:45 +00:00
konrad merged commit d67e5e386d into main 2022-09-21 14:24:00 +00:00
konrad deleted branch feature/feat-pinia-label-store 2022-09-21 14:24:00 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.