vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: possible fix for pnpm ci errors #2413

Merged
konrad merged 3 commits from dpschen/frontend:feature/possible-pnpn-fix into main 2022-09-27 15:37:26 +00:00
Conversation 2 Commits 3 Files Changed 2 +13 -12
dpschen commented 2022-09-24 16:35:16 +00:00
Member
Copy Link
No description provided.
dpschen requested review from konrad 2022-09-24 16:35:23 +00:00
konrad was assigned by dpschen 2022-09-24 16:35:27 +00:00
dpschen changed title from WIP: feat: possible fix for pnpm ci errors to feat: possible fix for pnpm ci errors 2022-09-26 11:41:06 +00:00
konrad reviewed 2022-09-26 12:12:35 +00:00
.drone.yml Outdated
@ -47,3 +47,3 @@
CYPRESS_CACHE_FOLDER: .cache/cypress
commands:
- corepack enable && corepack prepare pnpm@7.9.3 --activate && pnpm config set store-dir .cache/pnpm
- corepack enable && corepack prepare pnpm@7.12.2 --activate && pnpm config set store-dir .cache/pnpm
konrad commented 2022-09-26 12:12:35 +00:00
Owner

Do we need to change this every time a new pnpm version is released?

Do we need to change this every time a new pnpm version is released?
dpschen commented 2022-09-26 13:03:07 +00:00
Author
Member

The corepack prepare might not be necessary after all: https://pnpm.io/installation#using-corepack
I removed it. Let's see if that works.
If I understand it correctly it should then use the version defined in package.json.

The corepack prepare might not be necessary after all: https://pnpm.io/installation#using-corepack I removed it. Let's see if that works. If I understand it correctly it should then use the version defined in `package.json`.
👍 1
dpschen commented 2022-09-27 14:40:18 +00:00
Author
Member

Seems to work.

Seems to work.
dpschen marked this conversation as resolved
frederick commented 2022-09-26 16:13:58 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2413-feature-possible-pnpn-fix--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2413-feature-possible-pnpn-fix--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/possible-pnpn-fix from b926d8670b to a199fc7a8e 2022-09-27 09:25:37 +00:00 Compare
dpschen commented 2022-09-27 09:26:17 +00:00
Author
Member
Copy Link

I think you need to sign this again, since I had to rebase to include the http => https change.

I think you need to sign this again, since I had to rebase to include the http => https change.
konrad added 1 commit 2022-09-27 15:20:55 +00:00
continuous-integration/drone/pr Build is passing Details
f4a5f59400
chore(ci): sign drone config
konrad approved these changes 2022-09-27 15:21:19 +00:00
konrad scheduled this pull request to auto merge when all checks succeed 2022-09-27 15:21:43 +00:00
konrad merged commit bc833091f2 into main 2022-09-27 15:37:26 +00:00
konrad deleted branch feature/possible-pnpn-fix 2022-09-27 15:38:46 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2413
No description provided.
Delete Branch "dpschen/frontend:feature/possible-pnpn-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?