feat NewNamespace script setup #2415

dpschen · 2022-09-24T18:35:05Z

dpschen commented

2022-09-24 18:35:05 +00:00

No description provided.

frederick commented

2022-09-26 11:43:23 +00:00

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2415-feature-feat-newnamespace-script--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2415-feature-feat-newnamespace-script--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen requested review from konrad 2022-09-26 12:51:53 +00:00

konrad was assigned by dpschen

2022-09-26 12:51:56 +00:00

konrad requested changes 2022-09-26 16:02:44 +00:00

konrad left a comment

Trying to create a new namespace results in an error message:

But the namespace is still created.

Trying to create a new namespace results in an error message: ![image](/attachments/6277f102-1f82-435f-8b96-be903c0abe5f) But the namespace is still created.

image.png

10 KiB

dpschen commented

2022-09-27 09:39:08 +00:00

Yes. I think that was an issue all along but just got obvious now that it's converted to script setup. See b24e9725fa/src/views/namespaces/NewNamespace.vue (L15)
The back function was not defined in the old version as well.
Not sure what the intend here is. I guess you meant to write $router.back, but it seems weird to use that on the input field, since it changes the view aka closes the whole component.

Yes. I think that was an issue all along but just got obvious now that it's converted to script setup. See https://kolaente.dev/vikunja/frontend/src/commit/b24e9725fae6df3982bf97da55421b53826abbbd/src/views/namespaces/NewNamespace.vue#L15 The `back` function was not defined in the old version as well. Not sure what the intend here is. I guess you meant to write `$router.back`, but it seems weird to use that on the input field, since it changes the view aka closes the whole component.

konrad commented

2022-09-27 15:11:10 +00:00

Not sure what the intend here is. I guess you meant to write $router.back, but it seems weird to use that on the input field, since it changes the view aka closes the whole component.

It should be $router.back(). The idea was that you could close the modal by pressing escape - that already works with the default modal but with the input modal here since it autofocuses the input that input field catches the focus instead. Hence I just placed the listener on the input field directly.

> Not sure what the intend here is. I guess you meant to write $router.back, but it seems weird to use that on the input field, since it changes the view aka closes the whole component. It should be `$router.back()`. The idea was that you could close the modal by pressing escape - that already works with the default modal but with the input modal here since it autofocuses the input that input field catches the focus instead. Hence I just placed the listener on the input field directly.

dpschen commented

2022-09-27 16:43:16 +00:00

That makes sense. Will fix!

dpschen force-pushed feature/feat-NewNamespace-script-setup from b24e9725fa to dbbbc1cc32

2022-09-27 16:47:38 +00:00

Compare

dpschen requested review from konrad 2022-09-27 17:10:07 +00:00

dpschen commented

2022-09-27 17:10:20 +00:00

@konrad Fixed

konrad requested changes 2022-09-27 17:16:44 +00:00

konrad left a comment