feat: Login script setup #2417

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-Login-script-setup into main 2022-10-01 15:58:40 +00:00
Member
No description provided.
Author
Member

Strange: somehow the Password component wasn't and obviously isn't used at all:
https://drone.kolaente.de/vikunja/frontend/10369/1/4

Strange: somehow the Password component wasn't and obviously isn't used at all: https://drone.kolaente.de/vikunja/frontend/10369/1/4
konrad was assigned by dpschen 2022-09-27 09:39:45 +00:00
konrad reviewed 2022-09-27 15:08:41 +00:00
@ -185,0 +133,4 @@
const hasOpenIdProviders = computed(() => openidConnect.value.enabled && openidConnect.value.providers?.length > 0)
const loading = computed(() => store.state.loading)
function setLoading() {

Isn't there a helper function already somewhere for this?

Isn't there a helper function already somewhere for this?
Author
Member

Removed

Removed
dpschen marked this conversation as resolved
Owner

Strange: somehow the Password component wasn't and obviously isn't used at all:

That doesn't make any sense... where is that password field coming from?

> Strange: somehow the Password component wasn't and obviously isn't used at all: That doesn't make any sense... where is that password field coming from?
Author
Member

Okay, maybe I removed that again when I rebased... It came originally from here 0322daf4d4

Will check.

Okay, maybe I removed that again when I rebased... It came originally from here https://kolaente.dev/vikunja/frontend/commit/0322daf4d459f9108cb71902381f1dd1a2b06c57 Will check.
dpschen force-pushed feature/feat-Login-script-setup from 701a1a08f8 to 00350b46c0 2022-09-29 09:16:36 +00:00 Compare
dpschen force-pushed feature/feat-Login-script-setup from 00350b46c0 to 791ab887a9 2022-09-29 12:18:25 +00:00 Compare
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2417-feature-feat-login-script-setup--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2417-feature-feat-login-script-setup--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
Owner

Looks like the password field now has a different id:

https://drone.kolaente.de/vikunja/frontend/10470/1/8

Looks like the password field now has a different id: https://drone.kolaente.de/vikunja/frontend/10470/1/8
dpschen force-pushed feature/feat-Login-script-setup from 791ab887a9 to bd60b8555d 2022-09-30 10:53:06 +00:00 Compare
dpschen force-pushed feature/feat-Login-script-setup from bd60b8555d to 9d2a418272 2022-10-01 13:39:14 +00:00 Compare
dpschen force-pushed feature/feat-Login-script-setup from 9d2a418272 to 4df54e53a9 2022-10-01 14:17:45 +00:00 Compare
dpschen force-pushed feature/feat-Login-script-setup from 4df54e53a9 to c014e90a1b 2022-10-01 14:40:03 +00:00 Compare
dpschen force-pushed feature/feat-Login-script-setup from c014e90a1b to 90e1f9fbbd 2022-10-01 14:47:07 +00:00 Compare
dpschen changed title from WIP: feat: Login script setup to feat: Login script setup 2022-10-01 14:51:43 +00:00
dpschen requested review from konrad 2022-10-01 14:51:48 +00:00
dpschen added the
area/internal-code
label 2022-10-01 14:51:53 +00:00
dpschen force-pushed feature/feat-Login-script-setup from 90e1f9fbbd to f31aa6a8c4 2022-10-01 15:02:56 +00:00 Compare
konrad approved these changes 2022-10-01 15:05:13 +00:00
Dismissed
Owner

When opening the page, it tries to directly verify the email and the password field is missing:

image

When opening the page, it tries to directly verify the email and the password field is missing: ![image](/attachments/96e3d0f2-8930-4474-828a-9c7e75bb1df5)
konrad dismissed konrad’s review 2022-10-01 15:06:37 +00:00
dpschen force-pushed feature/feat-Login-script-setup from f31aa6a8c4 to 1a3dbc7575 2022-10-01 15:18:21 +00:00 Compare
konrad approved these changes 2022-10-01 15:58:34 +00:00
konrad merged commit 63fb8a1962 into main 2022-10-01 15:58:40 +00:00
konrad deleted branch feature/feat-Login-script-setup 2022-10-01 15:58:41 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.