vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: automatically create subtask relations based on indention #2443

Merged
konrad merged 6 commits from feature/subtask-via-indention into main 2022-09-30 11:47:22 +00:00
Conversation 1 Commits 6 Files Changed 3 +5 -1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d58f8b4ba1 - Show all commits

6
src/helpers/parseSubtasksViaIndention.ts
View File

@ -20,10 +20,14 @@ export function parseSubtasksViaIndention(taskTitles: string): TaskWithParent[]
parent: null,
}
if (index === 0) {
konrad marked this conversation as resolved Outdated
dpschen commented 2022-09-28 19:13:21 +00:00
Outdated
Review
Copy Link

Move matched and matchedSpaces in condition aswell since it's not used for index === 0

Move `matched` and `matchedSpaces` in condition aswell since it's not used for `index === 0`
konrad commented 2022-09-29 16:10:08 +00:00
Outdated
Review
Copy Link

Added an earlier break for index === 0.

Added an earlier break for `index === 0`.
👍 1
return task
}
const matched = spaceRegex.exec(title)
const matchedSpaces = matched ? matched[0].length : 0
if (matchedSpaces > 0 && index > 0) {
if (matchedSpaces > 0) {
// Go up the tree to find the first task with less indention than the current one
let pi = 1
let parentSpaces = 0