vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: fancycheckbox script setup #2462

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-fancycheckbox-script-setup into main 2022-10-03 20:19:37 +00:00
Conversation 1 Commits 1 Files Changed 1 +32 -36
dpschen commented 2022-10-02 18:13:51 +00:00
Member
Copy Link
No description provided.
frederick commented 2022-10-02 18:16:46 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2462-feature-feat-fancycheckbox-scrip--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2462-feature-feat-fancycheckbox-scrip--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2022-10-02 19:16:40 +00:00
src/components/input/fancycheckbox.vue Outdated
@ -52,2 +28,2 @@
immediate: true,
},
const checked = ref(false)
const checkBoxId = ref(`fancycheckbox_${createRandomID()}`)
konrad commented 2022-10-02 19:16:40 +00:00
Owner

I think this doesn't even need to be a ref.

I think this doesn't even need to be a `ref`.
👍 1
dpschen commented 2022-10-03 15:59:21 +00:00
Author
Member

Changed

Changed
dpschen marked this conversation as resolved
dpschen force-pushed feature/feat-fancycheckbox-script-setup from 1736e9dab8 to e7513d072b 2022-10-03 15:59:09 +00:00 Compare
dpschen changed title from WIP: feat: fancycheckbox script setup to feat: fancycheckbox script setup 2022-10-03 15:59:23 +00:00
dpschen requested review from konrad 2022-10-03 15:59:27 +00:00
konrad was assigned by dpschen 2022-10-03 15:59:30 +00:00
konrad merged commit 06c1a54886 into main 2022-10-03 20:19:37 +00:00
konrad deleted branch feature/feat-fancycheckbox-script-setup 2022-10-03 20:19:37 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2462
No description provided.
Delete Branch "dpschen/frontend:feature/feat-fancycheckbox-script-setup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?