feat: quick-actions script setup #2478
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#2478
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/quick-actions-script-setup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
92e6dbc126
tof5826456c8
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://2478-feature-quick-actions-script-set--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
@ -234,0 +246,4 @@
const placeholder = computed(() => selectedCmd.value?.placeholder || t('quickActions.placeholder'))
const currentList = computed(() => Object.keys(baseStore.currentList).length === 0
Isn't the
currentList
in the store eithernull
or defined?It should be. I actually don't get why you check the length here. This is ported directly from the options version. There it was:
of before:
Why does this check for the keys length?
I don't know, does the git log say anything useful?
@ -296,2 +321,3 @@
type Filter = {by: string, value: string | number, comparator: string}
const {text, list, labels} = this.parsedQuery
function filtersToParams(filters: Filter[]) {
I wonder if we could extract and reuse this function?
Yes! I have already some ideas to make this better. Here I mostly wanted to port it to typescript. I created this in order to have more overview in the file.
WIP: feat: quick-actions script setupto feat: quick-actions script setup