vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: unify savedFilter logic in service #2491

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-unify-saved-filter-logic into main 2022-10-27 19:56:16 +00:00
Conversation 1 Commits 1 Files Changed 10 +155 -167
dpschen commented 2022-10-04 20:39:15 +00:00
Member
Copy Link
No description provided.
dpschen force-pushed feature/feat-unify-saved-filter-logic from 19178d95bf to 6af7812918 2022-10-27 14:25:55 +00:00 Compare
dpschen changed title from WIP: feat: unify savedFilter logic in service to feat: unify savedFilter logic in service 2022-10-27 14:26:18 +00:00
dpschen requested review from konrad 2022-10-27 14:26:21 +00:00
konrad was assigned by dpschen 2022-10-27 14:26:24 +00:00
frederick commented 2022-10-27 14:30:08 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2491-feature-feat-unify-saved-filter---vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2491-feature-feat-unify-saved-filter---vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2022-10-27 19:52:57 +00:00
src/services/savedFilter.ts
@ -5,0 +29,4 @@
return listId
}
export function getSavedFilterIdFromListId(listId: IList['id']) {
konrad commented 2022-10-27 19:52:57 +00:00
Owner

Isn't this function doing the same as getListId?

Isn't this function doing the same as `getListId`?
konrad commented 2022-10-27 19:53:16 +00:00
Owner

ahhh it is not - missed the <.

ahhh it is not - missed the `<`.
konrad marked this conversation as resolved
konrad merged commit 9807858436 into main 2022-10-27 19:56:16 +00:00
konrad deleted branch feature/feat-unify-saved-filter-logic 2022-10-27 19:56:16 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2491
No description provided.
Delete Branch "dpschen/frontend:feature/feat-unify-saved-filter-logic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?