vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: improved types #2547

Merged
konrad merged 17 commits from dpschen/frontend:feature/improved-types into main 2022-11-02 16:06:57 +00:00
Conversation 7 Commits 17 Files Changed 63 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 53c9a9bc9c - Show all commits

3
tsconfig.app.json
View File

@ -18,6 +18,7 @@
}
},
"vueCompilerOptions": {
"strictTemplates": true
// "strictTemplates": true
dpschen commented 2022-10-20 09:29:35 +00:00
Outdated
Review
Copy Link

Unsure about this

Unsure about this
dpschen commented 2022-10-27 13:59:00 +00:00
Outdated
Review
Copy Link

Biggest reason why I can't judge this: Even after the merge of this branch we still have so many type errors that I don't know which errors appear / disappear when I toggle this option.

Biggest reason why I can't judge this: Even after the merge of this branch we still have so many type errors that I don't know which errors appear / disappear when I toggle this option.
konrad commented 2022-10-27 19:40:37 +00:00
Outdated
Review
Copy Link

Is there any difference in the number of errors?

Is there any difference in the number of errors?
dpschen commented 2022-10-28 16:25:27 +00:00
Outdated
Review
Copy Link

Without "strictTemplates": true (I guess the default is false ;) )

Found 917 errors in 154 files.

With "strictTemplates": true

Found 949 errors in 159 files.

As said: I do not know which errors these are. It might also be that some disappear while others emerge.

Without `"strictTemplates": true` (I guess the default is false ;) ) ``` Found 917 errors in 154 files. ``` With `"strictTemplates": true` ``` Found 949 errors in 159 files. ``` As said: I do not know which errors these are. It might also be that some disappear while others emerge.
"jsxTemplates": true
}
}